*: ensure all tests are using Bazel-friendly testutils.TestDataPath() function rather than literal testdata
#71928
Labels
A-build-system
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-dev-inf
X-nostale
Marks an issue/pr that should be ignored by the stale bot
Comments
rickystewart
added
C-enhancement
This was referenced Jan 19, 2022
craig bot
pushed a commit
that referenced
this issue
Jan 20, 2022
74737: spanconfigsqltranslator: introduce a pts table reader r=adityamaru a=adityamaru This change introduces a `ProtectedTimestampTableReader` that provides a txn scoped, in-memory view of the system table that stores protected timestamp records. The `SQLTranslator` will use this table reader to generate SpanConfigs and SystemSpanConfigs in a follow up PR. Informs: #73727 Release note: None 75125: *: replace "testdata" with sed scripts r=rickystewart a=otan Not a proper audit, but 80% of the way there. Refs: #71928 See individual commits for details 75161: randgen: do not create computed columns with bad volatilities r=mgartner a=mgartner Some cast to STRING types has been given an incorrect volatility. For example, REGCLASS->STRING casts are immutable when they should be stable (see #74286 and #74553 for more details). Creating computed column expressions with such a cast can cause logical correctness bugs and internal errors. The volatilities cannot be fixed without causing backward incompatibility. This commit prevents `randgen` from creating computed columns with these casts so that sqlsmith and TLP do not repetitively find these known volatility bugs. Informs #74727 Release note: None 75165: kv: fix GenerateForcedRetryableError to return a bumped epoch r=lidorcarmel a=lidorcarmel This is needed for PR #74563, where we change how txn is reset. Without this change GenerateForcedRetryableError returns an error with an inner txn that has an epoch 0. With this change the epoch is copied from the original txn. Release note: None Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Lidor Carmel <lidor@cockroachlabs.com>
|
We have marked this issue as stale because it has been inactive for |
rickystewart
added
X-nostale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previous discussion: #71889 (comment)
Epic CRDB-17171
Jira issue: CRDB-10836
The text was updated successfully, but these errors were encountered: