Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protectedts: switch backup, changefeed tests to use the new protected timestamp subsystem #77495

Closed
Tracked by #73727
arulajmani opened this issue Mar 8, 2022 · 2 comments
Assignees
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery

Comments

@arulajmani
Copy link
Collaborator

arulajmani commented Mar 8, 2022

Describe the problem

Now that everything laid out in #73727 has landed, we have an end to end implementation for the new protected timestamp subsystem. This should allow us to switch over existing tests to leverage the new subsystem instead of the old one. This entails flipping:

// EnableProtectedTimestampForMultiTenant when set to true, runs the protected
// timestamp subsystem that depends on span configuration reconciliation.
//
// TODO(adityamaru,arulajmani): Default this to true, or flip it to
// `DisableProtectedTimestampForMultiTenant` prior to release 22.1.
EnableProtectedTimestampForMultiTenant bool
}

and fixing whatever the falls out as a result.

Jira issue: CRDB-13621

@arulajmani arulajmani added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. branch-master Failures and bugs on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 8, 2022
@adityamaru
Copy link
Contributor

Fixed by #77478

@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2022

cc @cockroachdb/bulk-io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants