index with long name break UI on database page #86559
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-observability
Comments
maryliag
added
C-bug
craig bot
pushed a commit
that referenced
this issue
Sep 26, 2022
88582: vendor: bump Pebble to 829c25fa5db3 r=nicktrav a=jbowens ``` 829c25fa db: fix RangeKeyChanged and -WithLimit interaction 0f464e9c sstable: fix interaction between bpf and monotonic bounds optimization 46a6a539 sstable: remove commented code 9a552270 db: fix TestRangeKeyMaskingRandomized 8418ebc2 build: bump min go version to 1.17 5f8eb821 *: remove references to `ioutil` 05a4b29c db: expand iter_histories test coverage 2855ba7c db: refactor TestRangeKeys into TestIterHistories ``` Release note: None 88615: bench: add a benchmark for update with assigment casts r=yuzefovich a=yuzefovich Informs: #88525. Release note: None 88673: stats: fix missing autostats on cluster startup r=msirek a=msirek Fixes #87247 Previously, automatic statistics may fail to be collected on tables with no stats at cluster startup when the `sql.stats.automatic_collection.enabled` cluster setting is false but table storage parameter `sql_stats_automatic_collection_enabled` is true. Method `ensureAllTables` does not put entries into the settingOverrides map, and since storage parameter info is not normally looked up in the table header in auto stats processing, we fall back on the cluster setting to determine if auto stats should be collected. To address this, this patch modifies auto stats to flag whether the current batch of tables saved in the mutationCounts map comes from cluster startup processing, and if so, ensures that storage parameters controlling auto stats are always looked up in the table header during that processing. Release note (bug fix): This patch fixes missing automatic statistics collection at cluster startup when the `sql.stats.automatic_collection.enabled` cluster setting is false, but there are tables with storage parameter `sql_stats_automatic_collection_enabled` set to true. 88718: storage: add log scoping to MVCC benchmarks r=erikgrinaker a=jbowens This prevents logs from being interleaved within benchmark output when using `--stream-output` with `dev bench`. Since the Pebble logs are chatty, this might have a non-neglible impact on the benchmark performance. I'll backport this to prior releases so that comparisons between the HEADs of the various release branches are comparing apples to apples. Release note: None 88724: ui: fix ui on dbconsole table detail page with very long index name r=amyyq2 a=amyyq2 Previously, when there was a very long index name, it would run off the edge of the summary card and cause the Index Stats table to scroll for a long time. This change wraps the index name text so the user can see the entirety of the name on the summary card and in the table. This change also fixed the width of the Index Stats table to be aligned with the other summary cards on the page. <img width="1203" alt="cluster-ui" src="https://user-images.githubusercontent.com/54999459/192319099-71c7734d-3ed1-4ee0-b6ee-568bd46f0dba.png"> Partially Fixes #86559 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: None 88730: cli: deprecate `debug unsafe-remove-dead-replicas` r=aliher1911 a=erikgrinaker This patch marks `unsafe-remove-dead-replicas` as deprecated, and refers users to the new `recover` commands. It will be removed in v23.1. Resolves #86543. Release note (cli change): The `debug unsafe-remove-dead-replicas` CLI command has been deprecated, and will be removed in v23.1. Users should use the new `debug recover` set of commands instead. Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Mark Sirek <sirek@cockroachlabs.com> Co-authored-by: Amy Qian <amy.qian@cockroachlabs.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
|
Partially closed by #10074 as well |
blathers-crl bot
pushed a commit
that referenced
this issue
Sep 26, 2022
…ex name Previously, when there was a very long index name, it would run off the edge of the summary card and cause the Index Stats table to scroll. This change wraps the index name text so the user can see the entirety of the name on the summary card and in the table. This change also fixed the width of the Index Stats table to be aligned with the other summary cards on the page. Fixes #86559 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checking an index with a really long name breaks the UI alignments, example can be seen on our staging serverless cluster, on database
randhttps://www.loom.com/share/2afb310faeb040869c22877f5c44a836
Jira issue: CRDB-18818
The text was updated successfully, but these errors were encountered: