Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogic_create_index failed #87575

Closed
cockroach-teamcity opened this issue Sep 8, 2022 · 1 comment · Fixed by #88468
Closed

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogic_create_index failed #87575

cockroach-teamcity opened this issue Sep 8, 2022 · 1 comment · Fixed by #88468
Labels
branch-release-22.2 Used to mark release blockers and technical advisories for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 8, 2022 •
edited by cockroach-jira-scripts
Loading

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogic_create_index failed with artifacts on release-22.2 @ f8e04f32b84a9727c9e813d0096bde2de64d5675:

=== RUN   TestTenantLogic_create_index/test_old_bucket_count_syntax
    logic.go:3058: 
        
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3949/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/create_index:379: 
        expected success, but found
        (XXUUU) job 794770461987438593 was paused before it completed with reason: pause point "indexbackfill.before_flow" hit
        wait.go:173: in waitForJobs()
    logic.go:2014: 
         pq: job 794770461987438593 was paused before it completed with reason: pause point "indexbackfill.before_flow" hit
[05:31:37] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3949/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/create_index with config 3node-tenant: 60 tests, 2 failures
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-19419
@cockroach-teamcity cockroach-teamcity added branch-release-22.2 Used to mark release blockers and technical advisories for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Sep 8, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Sep 8, 2022
@cockroach-teamcity cockroach-teamcity added this to Triage in SQL Queries Sep 8, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 8, 2022
@yuzefovich yuzefovich added this to Triage in SQL Foundations via automation Sep 9, 2022
@yuzefovich yuzefovich removed this from Triage in SQL Queries Sep 9, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Sep 9, 2022
@cockroach-teamcity
Copy link
Member Author

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogic_create_index failed with artifacts on release-22.2 @ 1adc3f0b396dc045c52729d249943889a495c652:

=== RUN   TestTenantLogic_create_index/test_old_bucket_count_syntax
    logic.go:3058: 
        
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3949/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/create_index:376: 
        expected success, but found
        (XXUUU) job 795053720975998977 was paused before it completed with reason: pause point "indexbackfill.before_flow" hit
        wait.go:173: in waitForJobs()
    logic.go:2014: 
         pq: job 795053720975998977 was paused before it completed with reason: pause point "indexbackfill.before_flow" hit
[05:32:32] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3949/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/create_index with config 3node-tenant: 59 tests, 2 failures
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@ajwerner ajwerner self-assigned this Sep 20, 2022
@postamar postamar moved this from Triage to General in SQL Foundations Sep 20, 2022
@ajwerner ajwerner mentioned this issue Sep 22, 2022
Closed
@ajwerner ajwerner mentioned this issue Sep 22, 2022
Merged
craig bot pushed a commit that referenced this issue Sep 22, 2022
@Xiang-Gu @nvanbenschoten
@ajwerner @fqazi @msbutler @knz
Merge #87808 #88082 #88459 #88468 #88475 #88476 #88478
d390148 
87808: norm: do not fold floor division with unit denominator r=msirek a=msirek

Fixes #87605

The floor division operator `//` is like division but drops the
fractional portion of the result. Normalization rule FoldDivOne
rewrites `(column // 1)` as `(column)` which is incorrect if the
data in `column` has fractional digits, as those digits should be
dropped.

The solution is to only fold `(column // 1)` when `column` is one of
the integer types.

Release note (bug fix): This patch fixes incorrect results from
the floor division operator, `//`, when the numerator is non-constant
and the denominator is the constant 1.

88082: *: audit operation names in new schema changer r=Xiang-Gu a=Xiang-Gu

This PR made non-functional changes related to new schema changer ops:
1. Rename all status changing operation on Index and Column to comform
to the pattern: `Make[StatusA][Index/Column][StatusB]`

2. Rename a few constant/field/function names to be consistent with the
principle of "being explicit":
  2.1. Rename operation name `XxxGcXxx` to `XxxGCXxx`;
  2.2. Rename field name in operations `DescID` to `DescriptorID`;
  2.3. Rename descpb.DELETE_AND_WRITE_ONLY to descpb.WRITE_ONLY;
  2.4. Rename sql.RunningStatusDeleteAndWriteOnly to sql.RunningStatusWriteOnly

3. Seveal comments enhencement

4. Rename `DELETE_AND_WRITE_ONLY` to `WRITE_ONLY` in some files under
docs/.

Fixes #84583

Release note: None

88459: kv: fix spelling of "interceptor" in file name r=nvanbenschoten a=nvanbenschoten

All other file names and code objects have the correct spelling.

Release justification: None.

Release note: None.

88468: kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob sometimes r=ajwerner a=ajwerner

We want to ignore the point deletion knob for cases where we're deleting data from system tables watched by rangefeeds. Not doing so can lead to missed updates. This is particularly critical for cluster settings.

Fixes #87575
Fixes #87479
Fixes #88202

Release note: None

88475: workload/schemachange/mixed-version: avoid index visibility r=fqazi a=fqazi

Fixes: #87768

Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes.

Release note: None

88476: multitenant: add TestTenants() helper to TestServer r=ajstorm a=msbutler

This patch adds a helper method for accessing information about the tenant(s) that were probabilistically created with the TestServer.

Release note: None

88478: cli/sql: increase maxHistEntries r=ajwerner a=knz

As discussed this morning.

In light of PR #88272, we don't need the limit to be as low as 1000. This commit increases it back to 10000, which is the common default in unix shells and the screen/tmux utilities.


Co-authored-by: Mark Sirek <sirek@cockroachlabs.com>
Co-authored-by: Xiang Gu <xiang@cockroachlabs.com>
Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Andrew Werner <awerner32@gmail.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig craig bot closed this as completed in d91e4f4 Sep 22, 2022
SQL Foundations automation moved this from General to Closed Sep 22, 2022
@blathers-crl blathers-crl bot mentioned this issue Sep 22, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Sep 22, 2022
@ajwerner
kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob som…
7df7fae 
…etimes

We want to ignore the point deletion knob for cases where we're deleting data
from system tables watched by rangefeeds. Not doing so can lead to missed
updates. This is particularly critical for cluster settings.

Fixes #87575
Fixes #87479

Release note: None
@healthy-pod healthy-pod added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 17, 2023
@blathers-crl blathers-crl bot added this to Done [after migration] in SQL Foundations May 17, 2023
@exalate-issue-sync exalate-issue-sync bot reopened this May 23, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label May 23, 2023
SQL Foundations automation moved this from Done [after migration] to Triage May 23, 2023
@rafiss rafiss closed this as completed Jun 1, 2023
SQL Foundations automation moved this from Triage to Done Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-22.2 Used to mark release blockers and technical advisories for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Done
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob sometimes ajwerner/cockroach
4 participants
@rafiss @ajwerner @cockroach-teamcity @healthy-pod