roachtest: schemachange/mixed-versions failed #87768
Assignees
Labels
branch-release-22.2
Used to mark release blockers and technical advisories for 22.2
C-test-failure
Broken test (automatically or manually discovered).
GA-blocker
O-roachtest
O-robot
Originated from a bot.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
Milestone
Comments
cockroach-teamcity
added
branch-release-22.2
ajwerner
added
GA-blocker
and removed
release-blocker
|
I think this might be fixed by #87706 (comment). @fqazi can you take a look if you find time? |
craig bot
pushed a commit
that referenced
this issue
Sep 22, 2022
87808: norm: do not fold floor division with unit denominator r=msirek a=msirek Fixes #87605 The floor division operator `//` is like division but drops the fractional portion of the result. Normalization rule FoldDivOne rewrites `(column // 1)` as `(column)` which is incorrect if the data in `column` has fractional digits, as those digits should be dropped. The solution is to only fold `(column // 1)` when `column` is one of the integer types. Release note (bug fix): This patch fixes incorrect results from the floor division operator, `//`, when the numerator is non-constant and the denominator is the constant 1. 88082: *: audit operation names in new schema changer r=Xiang-Gu a=Xiang-Gu This PR made non-functional changes related to new schema changer ops: 1. Rename all status changing operation on Index and Column to comform to the pattern: `Make[StatusA][Index/Column][StatusB]` 2. Rename a few constant/field/function names to be consistent with the principle of "being explicit": 2.1. Rename operation name `XxxGcXxx` to `XxxGCXxx`; 2.2. Rename field name in operations `DescID` to `DescriptorID`; 2.3. Rename descpb.DELETE_AND_WRITE_ONLY to descpb.WRITE_ONLY; 2.4. Rename sql.RunningStatusDeleteAndWriteOnly to sql.RunningStatusWriteOnly 3. Seveal comments enhencement 4. Rename `DELETE_AND_WRITE_ONLY` to `WRITE_ONLY` in some files under docs/. Fixes #84583 Release note: None 88459: kv: fix spelling of "interceptor" in file name r=nvanbenschoten a=nvanbenschoten All other file names and code objects have the correct spelling. Release justification: None. Release note: None. 88468: kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob sometimes r=ajwerner a=ajwerner We want to ignore the point deletion knob for cases where we're deleting data from system tables watched by rangefeeds. Not doing so can lead to missed updates. This is particularly critical for cluster settings. Fixes #87575 Fixes #87479 Fixes #88202 Release note: None 88475: workload/schemachange/mixed-version: avoid index visibility r=fqazi a=fqazi Fixes: #87768 Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes. Release note: None 88476: multitenant: add TestTenants() helper to TestServer r=ajstorm a=msbutler This patch adds a helper method for accessing information about the tenant(s) that were probabilistically created with the TestServer. Release note: None 88478: cli/sql: increase maxHistEntries r=ajwerner a=knz As discussed this morning. In light of PR #88272, we don't need the limit to be as low as 1000. This commit increases it back to 10000, which is the common default in unix shells and the screen/tmux utilities. Co-authored-by: Mark Sirek <sirek@cockroachlabs.com> Co-authored-by: Xiang Gu <xiang@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Sep 23, 2022
Fixes: cockroachdb#87768 Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes. Release note: None
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Oct 11, 2022
Fixes: cockroachdb#87768 Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes. Release note: None
exalate-issue-sync
bot
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
roachtest.schemachange/mixed-versions failed with artifacts on release-22.2 @ 1bfe9bcda653f55ed3b4216610433b51b2ef0d8f:
Parameters:
ROACHTEST_cloud=gce,ROACHTEST_cpu=4,ROACHTEST_ssd=0Help
See: roachtest README
See: How To Investigate (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-19521
The text was updated successfully, but these errors were encountered: