Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acceptance,multitenant: TestDockerCLI/test_demo_multitenant.tcl is flakey #96239

Closed
irfansharif opened this issue Jan 30, 2023 · 4 comments · Fixed by #108631
Closed

acceptance,multitenant: TestDockerCLI/test_demo_multitenant.tcl is flakey #96239

irfansharif opened this issue Jan 30, 2023 · 4 comments · Fixed by #108631
Assignees
@knz
Labels
A-demo A-multitenancy Related to multi-tenancy branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-multitenant Issues owned by the multi-tenant virtual team

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Jan 30, 2023 •
edited by knz
Loading

Describe the problem

TestDockerCLI/test_demo_multitenant.tcl has flaked five times in the last 24h and is tripping up CI (link), most recently for #95905.

Jira issue: CRDB-24020

Epic CRDB-28893
@irfansharif irfansharif added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). labels Jan 30, 2023
@irfansharif irfansharif mentioned this issue Jan 30, 2023
Merged
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jan 30, 2023
@irfansharif
acceptance: skip TestDockerCLI/test_demo_multitenant.tcl
7f9f3ea 
Informs cockroachdb#96239.

Release note: None
craig bot pushed a commit that referenced this issue Jan 30, 2023
@irfansharif
Merge #96240
53f394d 
96240: acceptance: skip TestDockerCLI/test_demo_multitenant.tcl r=irfansharif a=irfansharif

Informs #96239.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@knz
Copy link
Contributor

knz commented Feb 1, 2023

More tests skipped in #96339.

@knz knz added A-demo A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team labels Feb 1, 2023
@knz knz mentioned this issue Feb 1, 2023
Merged
@knz
Copy link
Contributor

knz commented Feb 1, 2023

Possibly relates to #96162.

craig bot pushed a commit that referenced this issue Feb 1, 2023
@knz
Merge #96339
0fbaa27 
96339: cli/interactive_tests: skip some flaky tests r=msbutler a=knz

Informs #96239
These tests are currently flaky. Disable them until a followup investigation.

Release note: None
Epic: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@rafiss rafiss mentioned this issue Feb 10, 2023
Closed
@ajstorm ajstorm added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 7, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 7, 2023

Hi @ajstorm, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@ajstorm ajstorm added the branch-master Failures and bugs on the master branch. label Mar 7, 2023
@dhartunian dhartunian added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 GA-blocker labels Mar 8, 2023
@knz knz removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. GA-blocker labels Mar 13, 2023
@rafiss rafiss mentioned this issue Jul 8, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 8, 2023
@rafiss
Merge #106463
43c26ae 
106463: interactive_tests: preserve demo logs in tests r=knz a=rafiss

Now we pass in the --log-dir option so that logs are saved when the test fails. Otherwise, the demo command does not log.

This also unskips two tests that should be working now.

informs #96450
informs #102257
informs #100319
informs #106462
informs #106461
informs #96797
informs #96239


Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@rafiss rafiss mentioned this issue Jul 9, 2023
Merged
@knz knz mentioned this issue Aug 10, 2023
Merged
craig bot pushed a commit that referenced this issue Aug 11, 2023
@knz
Merge #108566
9ac5f22 
108566: cli/demo: various fixes r=rafiss a=knz

See individual commits for details.

Informs (and will fix after backport) #96239.
Fixes #102257.
Fixes #108331.
Fixes #108563.
Fixes #107888.

Epic: CRDB-28893

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@knz knz mentioned this issue Aug 11, 2023
Merged
@knz knz linked a pull request Aug 11, 2023 that will close this issue
release-23.1: cli/demo: various fixes #108631
Merged
@knz
Copy link
Contributor

knz commented Aug 11, 2023

closed by #108631

@knz knz closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-demo A-multitenancy Related to multi-tenancy branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release-23.1: cli/demo: various fixes knz/cockroach
6 participants
@knz @stevendanna @dhartunian @rafiss @irfansharif @ajstorm