-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101267
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101267
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
…ivenFKCascadesClusterLimit Fixes #101265 `SessionData` available to in the job context has a 0-value `OptimizerFKCascadesLimit`. This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error `cascades limit (0) reached`. This change fixes this by populating OptimizerFKCascadesLimit in `sql.NewFakeSessionData`. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be backported all the way back, or just ones we support TTL for?
I think it is better to backport this to prevent unexpected behavior. It would be easy to alter a table with |
bors r=otan |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-22.2-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101317/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101318/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1.0-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101319/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.0 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #101265
SessionData
available to in the job context has a 0-valueOptimizerFKCascadesLimit
.This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error
cascades limit (0) reached
.This change fixes this by populating OptimizerFKCascadesLimit in
sql.NewFakeSessionData
.Release note: None