Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101267

Merged
merged 1 commit into from
Apr 12, 2023
Merged

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101267

merged 1 commit into from
Apr 12, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Apr 11, 2023

Fixes #101265

SessionData available to in the job context has a 0-value OptimizerFKCascadesLimit.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error cascades limit (0) reached.

This change fixes this by populating OptimizerFKCascadesLimit in sql.NewFakeSessionData.

Release note: None

@ecwall ecwall requested review from rafiss and a team April 11, 2023 23:03
@blathers-crl
Copy link

blathers-crl bot commented Apr 11, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
@ecwall ecwall added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Apr 11, 2023
@ecwall ecwall requested a review from otan April 11, 2023 23:06
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be backported all the way back, or just ones we support TTL for?

@ecwall
Copy link
Contributor Author

ecwall commented Apr 12, 2023

does this need to be backported all the way back, or just ones we support TTL for?

I think it is better to backport this to prevent unexpected behavior. It would be easy to alter a table with ON DELETE CASCADE and have it affect a seemingly unrelated job (or anything else using NewFakeSessionData).

@ecwall
Copy link
Contributor Author

ecwall commented Apr 12, 2023

bors r=otan

@craig
Copy link
Contributor

craig bot commented Apr 12, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Apr 12, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-22.2-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101317/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 22.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.1-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101318/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.1.0-101267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/101319/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.0 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit
3 participants