Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101319

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 12, 2023

Backport 1/1 commits from #101267 on behalf of @ecwall.

/cc @cockroachdb/release


Fixes #101265

SessionData available to in the job context has a 0-value OptimizerFKCascadesLimit.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error cascades limit (0) reached.

This change fixes this by populating OptimizerFKCascadesLimit in sql.NewFakeSessionData.

Release note: None


Release justification:

…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 12, 2023 14:23
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.0-101267 branch from b23d744 to 0c86fac Compare April 12, 2023 14:23
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 12, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 12, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented May 4, 2023

Reminder: it has been 3 weeks please merge or close your backport!

@rafiss
Copy link
Collaborator

rafiss commented May 9, 2023

this is a duplicate of #101343

@rafiss rafiss closed this May 9, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1.0-101267 branch May 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants