importccl: fix panic when importing tables with storage options #66899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, when IMPORT encountered a table schema that specified certain geospacial storage options, it would cause the node to panic. Setting some options on geospacial tables/indexes would trigger a notice to be sent. However, IMPORT's synthesized evalCtx (used to create the schema) did not set a ClientNoticeSender, causing any notices sent during schema creation to panic. This change updates the synthesized evalCtx to use a dummy client, which is appropriate in the context of an import job since there may be no client to send the notice back to. Release note (bug fix): Fix a case where IMPORT would panic when parsing geospacial schemas with spacial index tuning parameters. In particular, this bug could be triggered by specifying the `fillfactor` option, or setting the `autovacuum_enabled` option to false.
dt
approved these changes
Jul 1, 2021
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when IMPORT encountered a table schema that specified
certain geospacial storage options, it would cause the node to panic.
Setting some options on geospacial tables/indexes would trigger a notice
to be sent. However, IMPORT's synthesized evalCtx (used to create the
schema) did not set a ClientNoticeSender, causing any notices sent
during IMPORT schema creation to panic.
This change updates the synthesized evalCtx to use a dummy client, which
is appropriate in the context of an import job since there may be no
client to send the notice back to.
Fixes #66905.
Release note (bug fix): Fix a case where IMPORT would panic when parsing
geospacial schemas with spacial index tuning parameters. In particular,
this bug could be triggered by specifying the
fillfactoroption, orsetting the
autovacuum_enabledoption to false.