sql: use qualifiable schema name for comment on schema #79055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chengxiong-ruan
force-pushed
the
comment-on-schema-use-qulifiable-name
branch
from
12ee5b8
to
4f259ec
Compare
ajwerner
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
I don't think you need to our ought to backport this
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
pkg/sql/comment_on_schema.go, line 47 at r1 (raw file):
dbName = n.Name.Catalog() } else { // Users can't create a schema without being connected to a DB.
this comment is now stale, no?
chengxiong-ruan
commented
Mar 30, 2022
There was a problem hiding this comment.
yeah, I'll remove the flag before merging it.
Reviewable status:
pkg/sql/comment_on_schema.go, line 47 at r1 (raw file):
Previously, ajwerner wrote…
this comment is now stale, no?
ha yeah, my understanding on this comment was that we can always get a current db anyhow. but this seems not important anymore here, will remove it.
Previously we only use current db to resolve a schema when comment on a schema. This is painful at least for our testing sometimes because we need to switch db before commenting on a schema. Release justification: low impact but can be useful for users. Release note (sql change): `COMMENT ON SCHEMA` now can use qualified schema name. So can do both `COMMENT ON SCHEMA sc_name ...` and `COMMENT ON SCHEMA db_name.sc_name ...`.
chengxiong-ruan
force-pushed
the
comment-on-schema-use-qulifiable-name
branch
from
4f259ec
to
029239a
Compare
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only use current db to resolve a schema when comment
on a schema. This is painful at least for our testing sometimes
because we need to switch db before commenting on a schema.
Release justification: low impact but can be useful for users.
Release note (sql change):
COMMENT ON SCHEMAnow can use qualifiedschema name. So can do both
COMMENT ON SCHEMA sc_name ...andCOMMENT ON SCHEMA db_name.sc_name ....