manifest: allow specifying blob file creation time

Allow specifying a blob file's creation time when parsing the debug string
representation used in tests. The creation time will be relevant for blob file
replacement heuristics.

Author: jbowens

internal/manifest/blob_metadata.go

@@ -173,7 +173,7 @@ func ParseBlobFileMetadataDebug(s string) (_ BlobFileMetadata, err error) {
 	}()
 
 	// Input format:
-	//  B000102 physical:{000000: size:[206536 (201KiB)], vals:[393256 (384KiB)]}
+	//  B000102 physical:{000000: size:[206536 (201KiB)], vals:[393256 (384KiB)] creationTime:1718851200}
 	p := strparse.MakeParser(debugParserSeparators, s)
 	fileID := p.BlobFileID()
 	p.Expect("physical")
@@ -201,7 +201,7 @@ func ParsePhysicalBlobFileDebug(s string) (_ *PhysicalBlobFile, err error) {
 	}()
 
 	// Input format:
-	//  000000: size:[206536 (201KiB)], vals:[393256 (384KiB)]
+	//  000000: size:[206536 (201KiB)], vals:[393256 (384KiB)] creationTime:1718851200
 	p := strparse.MakeParser(debugParserSeparators, s)
 	return parsePhysicalBlobFileDebug(&p)
 }
@@ -233,6 +233,8 @@ func parsePhysicalBlobFileDebug(p *strparse.Parser) (*PhysicalBlobFile, error) {
 			m.ValueSize = p.Uint64()
 			maybeSkipParens()
 			p.Expect("]")
+		case "creationTime":
+			m.CreationTime = p.Uint64()
 		default:
 			p.Errf("unknown field %q", field)
 		}

internal/manifest/blob_metadata_test.go

@@ -16,24 +16,32 @@ import (
 
 func TestPhysicalBlobFile_ParseRoundTrip(t *testing.T) {
 	testCases := []struct {
-		name   string
-		input  string
-		output string
+		name         string
+		input        string
+		output       string
+		creationTime uint64
 	}{
 		{
 			name:  "verbatim",
 			input: "000001 size:[903530 (882KB)] vals:[39531 (39KB)]",
 		},
 		{
-			name:   "whitespace is insignificant",
-			input:  "000001   size  : [ 903530 (882KB )] vals: [ 39531 ( 39KB ) ]",
-			output: "000001 size:[903530 (882KB)] vals:[39531 (39KB)]",
+			name:         "whitespace is insignificant",
+			input:        "000001   size  : [ 903530 (882KB )] vals: [ 39531 ( 39KB ) ] creationTime:   1718851200",
+			output:       "000001 size:[903530 (882KB)] vals:[39531 (39KB)]",
+			creationTime: 1718851200,
 		},
 		{
 			name:   "humanized sizes are optional",
 			input:  "000001 size:[903530] vals:[39531]",
 			output: "000001 size:[903530 (882KB)] vals:[39531 (39KB)]",
 		},
+		{
+			name:         "creation time is optional",
+			input:        "000001 size:[903530 (882KB)] vals:[39531 (39KB)] creationTime:1718851200",
+			output:       "000001 size:[903530 (882KB)] vals:[39531 (39KB)]",
+			creationTime: 1718851200,
+		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
@@ -45,6 +53,7 @@ func TestPhysicalBlobFile_ParseRoundTrip(t *testing.T) {
 				want = tc.output
 			}
 			require.Equal(t, want, got)
+			require.Equal(t, tc.creationTime, m.CreationTime)
 		})
 	}
 }
@@ -61,14 +70,19 @@ func TestBlobFileMetadata_ParseRoundTrip(t *testing.T) {
 		},
 		{
 			name:   "whitespace is insignificant",
-			input:  "B000002          physical : {000001   size  : [ 903530 (882KB )] vals: [ 39531 ( 39KB ) ]  }",
+			input:  "B000002          physical : {000001   size  : [ 903530 (882KB )] vals: [ 39531 ( 39KB ) ] creationTime:   1718851200  }",
 			output: "B000002 physical:{000001 size:[903530 (882KB)] vals:[39531 (39KB)]}",
 		},
 		{
 			name:   "humanized sizes are optional",
 			input:  "B000002 physical:{000001 size:[903530] vals:[39531]}",
 			output: "B000002 physical:{000001 size:[903530 (882KB)] vals:[39531 (39KB)]}",
 		},
+		{
+			name:   "creation time is optional",
+			input:  "B000002 physical:{000001 size:[903530 (882KB)] vals:[39531 (39KB)] creationTime:1718851200}",
+			output: "B000002 physical:{000001 size:[903530 (882KB)] vals:[39531 (39KB)]}",
+		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {

internal/manifest/version_edit_test.go

@@ -484,6 +484,10 @@ func TestParseVersionEditDebugRoundTrip(t *testing.T) {
 		{
 			input: `  add-blob-file: B000925 physical:{000005 size:[20535 (20KB)] vals:[25935 (25KB)]}`,
 		},
+		{
+			input:  `  add-blob-file: B000925 physical:{000005 size:[20535 (20KB)] vals:[25935 (25KB)] creationTime:1718851200}`,
+			output: `  add-blob-file: B000925 physical:{000005 size:[20535 (20KB)] vals:[25935 (25KB)]}`,
+		},
 		{
 			input: `  add-table:     L1 000001:[a#0,SET-z#0,DEL] seqnums:[0-0] points:[a#0,SET-z#0,DEL] size:1`,
 		},