Skip to content

Commit 26e9e35

Browse files
committed
wal: fix flake in TestFailoverWriter
Fixes #5268
1 parent 34f641b commit 26e9e35

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

wal/testdata/failover_writer/blocking

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,14 @@ offset: 35
7777
# Because we did not request a sync, the log writer is not trying to do a
7878
# write. But the record is in the log writer's buffer.
7979
#
80-
# TODO(sumeer): this flakes under stress, with the flushLoop picking up the
81-
# write even though it should not. Fix or remove.
82-
ongoing-latency writer-index=0 none
83-
----
84-
no ongoing
80+
# Unfortunately this flakes under stress, with the flushLoop sometimes picking
81+
# up the write, possibly because of a spurious signal to the flusherCond
82+
# conditional variable. It doesn't really matter to the test whether the log
83+
# writer is blocked here or not, so we don't check.
84+
#
85+
# ongoing-latency writer-index=0 none
86+
# ----
87+
# no ongoing
8588

8689
# Block writes on the second log file too, which we haven't created yet.
8790
blocking-conf filename=000001-001.log write

0 commit comments

Comments
 (0)