-
Notifications
You must be signed in to change notification settings - Fork 451
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
db: add compaction callbacks for unexpected SingleDelete behavior
Two callbacks are added to Options: - IneffectualSingleDeleteCallback is called when a SingleDelete is being elided without encountering a Set/Merge/SetWithDelete. - SingleDeleteInvariantViolationCallback is called when a SingleDelete has at least a pair of Set/Merge/SetWithDelete below it, since it violates the usage requirement of a SingleDelete. The metamorphic test now fails on the SingleDeleteInvariantViolationCallback. The support for Merge to be SingleDeleted, that was introduced in #3118, is slightly improved in that SingleDelete consumes a single Merge instead of turning into a Delete. A subsequent change in CockroachDB will fatal or increment a metric (based on cluster settings) for these callbacks. Informs cockroachdb/cockroach#115881
- Loading branch information
1 parent
e0f2ccd
commit 288bf0f
Showing
9 changed files
with
386 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.