manifest: change panic to Fatalf

RaduBerinde · RaduBerinde · commit 36f982af7c60 · 2025-08-22T08:05:02.000-07:00
This panic causes an "unlock of unlocked mutex" panic on unwinding, which obscures the original panic. Change to a `Fatalf`. Fixes #5225
diff --git a/db.go b/db.go
@@ -2795,7 +2795,7 @@ func (d *DB) rotateWAL() (newLogNum base.DiskFileNum, prevLogSize uint64) {
 	if err != nil {
 		// What to do here? Stumbling on doesn't seem worthwhile. If we failed to
 		// close the previous log it is possible we lost a write.
-		panic(err)
+		d.opts.Logger.Fatalf("pebble: error closing WAL; data loss possible if we continue: %s", err)
 	}
 	prevLogSize = uint64(offset)
 	metrics := d.mu.log.writer.Metrics()

Original file line number	Diff line number	Diff line change
`@@ -2795,7 +2795,7 @@ func (d *DB) rotateWAL() (newLogNum base.DiskFileNum, prevLogSize uint64) {`
`2795`	`2795`	`if err != nil {`
`2796`	`2796`	`// What to do here? Stumbling on doesn't seem worthwhile. If we failed to`
`2797`	`2797`	`// close the previous log it is possible we lost a write.`
`2798`		`- panic(err)`
	`2798`	`+ d.opts.Logger.Fatalf("pebble: error closing WAL; data loss possible if we continue: %s", err)`
`2799`	`2799`	`}`
`2800`	`2800`	`prevLogSize = uint64(offset)`
`2801`	`2801`	`metrics := d.mu.log.writer.Metrics()`