Skip to content

Commit 3825430

Browse files
committed
tool: remove empty version edit checking in manifest check command
The 'empty' check had grown stale as we've expanded the fields of the VersionEdit and is unnecessary.
1 parent cc5a0f5 commit 3825430

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

tool/manifest.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -529,9 +529,7 @@ func (m *manifestT) runCheck(cmd *cobra.Command, args []string) {
529529
return
530530
}
531531

532-
empty := true
533532
if ve.ComparerName != "" {
534-
empty = false
535533
cmp = m.comparers[ve.ComparerName]
536534
if cmp == nil {
537535
fmt.Fprintf(stdout, "%s: offset: %d comparer %s not found",
@@ -541,12 +539,7 @@ func (m *manifestT) runCheck(cmd *cobra.Command, args []string) {
541539
}
542540
m.fmtKey.setForComparer(ve.ComparerName, m.comparers)
543541
}
544-
empty = empty && ve.MinUnflushedLogNum == 0 && ve.ObsoletePrevLogNum == 0 &&
545-
ve.LastSeqNum == 0 && len(ve.DeletedTables) == 0 &&
546-
len(ve.NewTables) == 0
547-
if empty {
548-
continue
549-
}
542+
550543
// TODO(sbhola): add option to Apply that reports all errors instead of
551544
// one error.
552545
if v == nil {

0 commit comments

Comments
 (0)