constants: remove package

The constant expression `min(math.MaxUint32, math.MaxInt)` can just be
used directly instead (and is better self-documenting).

Author: RaduBerinde

internal/arenaskl/arena.go

@@ -18,11 +18,11 @@
 package arenaskl
 
 import (
+	"math"
 	"sync/atomic"
 	"unsafe"
 
 	"github.com/cockroachdb/errors"
-	"github.com/cockroachdb/pebble/internal/constants"
 	"github.com/cockroachdb/pebble/internal/invariants"
 )
 
@@ -40,14 +40,16 @@ var (
 	ErrArenaFull = errors.New("allocation failed because arena is full")
 )
 
+const MaxArenaSize = min(math.MaxUint32, math.MaxInt)
+
 // NewArena allocates a new arena using the specified buffer as the backing
 // store.
 func NewArena(buf []byte) *Arena {
-	if len(buf) > constants.MaxUint32OrInt {
+	if len(buf) > MaxArenaSize {
 		if invariants.Enabled {
 			panic(errors.AssertionFailedf("attempting to create arena of size %d", len(buf)))
 		}
-		buf = buf[:constants.MaxUint32OrInt]
+		buf = buf[:MaxArenaSize]
 	}
 	a := &Arena{
 		buf: buf,
@@ -61,10 +63,10 @@ func NewArena(buf []byte) *Arena {
 // Size returns the number of bytes allocated by the arena.
 func (a *Arena) Size() uint32 {
 	s := a.n.Load()
-	if s > constants.MaxUint32OrInt {
+	if s > MaxArenaSize {
 		// The last failed allocation can push the size higher than len(a.buf).
 		// Saturate at the maximum representable offset.
-		return constants.MaxUint32OrInt
+		return MaxArenaSize
 	}
 	return uint32(s)
 }

internal/arenaskl/arena_test.go

@@ -21,7 +21,6 @@ import (
 	"math"
 	"testing"
 
-	"github.com/cockroachdb/pebble/internal/constants"
 	"github.com/stretchr/testify/require"
 )
 
@@ -32,7 +31,7 @@ func newArena(n uint32) *Arena {
 // TestArenaSizeOverflow tests that large allocations do not cause Arena's
 // internal size accounting to overflow and produce incorrect results.
 func TestArenaSizeOverflow(t *testing.T) {
-	a := newArena(constants.MaxUint32OrInt)
+	a := newArena(MaxArenaSize)
 
 	// Allocating under the limit throws no error.
 	offset, err := a.alloc(math.MaxUint16, 1, 0)
@@ -44,10 +43,10 @@ func TestArenaSizeOverflow(t *testing.T) {
 	// overflow if 32-bit arithmetic was used. It shouldn't.
 	_, err = a.alloc(math.MaxUint32, 1, 0)
 	require.Equal(t, ErrArenaFull, err)
-	require.Equal(t, uint32(constants.MaxUint32OrInt), a.Size())
+	require.Equal(t, uint32(MaxArenaSize), a.Size())
 
 	// Continuing to allocate continues to throw an error.
 	_, err = a.alloc(math.MaxUint16, 1, 0)
 	require.Equal(t, ErrArenaFull, err)
-	require.Equal(t, uint32(constants.MaxUint32OrInt), a.Size())
+	require.Equal(t, uint32(MaxArenaSize), a.Size())
 }

internal/batchskl/skl.go

@@ -63,14 +63,13 @@ import (
 
 	"github.com/cockroachdb/errors"
 	"github.com/cockroachdb/pebble/internal/base"
-	"github.com/cockroachdb/pebble/internal/constants"
 )
 
 const (
 	maxHeight    = 20
 	maxNodeSize  = uint64(unsafe.Sizeof(node{}))
 	linksSize    = uint64(unsafe.Sizeof(links{}))
-	maxNodesSize = constants.MaxUint32OrInt
+	maxNodesSize = min(math.MaxUint32, math.MaxInt)
 )
 
 var (

internal/constants/constants.go

@@ -23,7 +23,6 @@ import (
 	"github.com/cockroachdb/pebble/internal/arenaskl"
 	"github.com/cockroachdb/pebble/internal/base"
 	"github.com/cockroachdb/pebble/internal/cache"
-	"github.com/cockroachdb/pebble/internal/constants"
 	"github.com/cockroachdb/pebble/internal/invariants"
 	"github.com/cockroachdb/pebble/internal/keyspan"
 	"github.com/cockroachdb/pebble/internal/manifest"
@@ -49,7 +48,7 @@ const (
 	//
 	// On 32-bit systems, slices are naturally limited to MaxInt (just short of
 	// 2GB).
-	maxBatchSize = constants.MaxUint32OrInt
+	maxBatchSize = min(math.MaxUint32, math.MaxInt)
 
 	// The max memtable size is limited by the uint32 offsets stored in
 	// internal/arenaskl.node, DeferredBatchOp, and flushableBatchEntry.
@@ -59,7 +58,7 @@ const (
 	//
 	// On 32-bit systems, slices are naturally limited to MaxInt (just short of
 	// 2GB).
-	maxMemTableSize = constants.MaxUint32OrInt
+	maxMemTableSize = min(math.MaxUint32, math.MaxInt)
 )
 
 // FileCacheSize can be used to determine the file