Skip to content

Commit 69e4395

Browse files
RaduBerindeRaduBerinde
committed
metrics: add separators before total rows
1 parent d411801 commit 69e4395

File tree

7 files changed

+62
-2
lines changed

7 files changed

+62
-2
lines changed

‎metrics.go‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -907,13 +907,17 @@ func (m *Metrics) String() string {
907907
// LSM level metrics.
908908
cur := wb.At(0, 0)
909909
cur = cur.WriteString(levelMetricsTableTopHeader).NewlineReturn()
910-
cur = levelMetricsTable.Render(cur, table.RenderOptions{}, slices.Collect(m.LevelMetricsIter())...)
910+
cur = levelMetricsTable.Render(cur, table.RenderOptions{
911+
HorizontalDividers: table.MakeHorizontalDividers(0, manifest.NumLevels),
912+
}, slices.Collect(m.LevelMetricsIter())...)
911913
cur.Offset(-1, 0).WriteString("total")
912914
cur = cur.NewlineReturn()
913915

914916
// Compaction level metrics.
915917
cur = cur.WriteString(levelCompactionMetricsTableTopHeader).NewlineReturn()
916-
cur = compactionLevelMetricsTable.Render(cur, table.RenderOptions{}, slices.Collect(m.LevelMetricsIter())...)
918+
cur = compactionLevelMetricsTable.Render(cur, table.RenderOptions{
919+
HorizontalDividers: table.MakeHorizontalDividers(0, manifest.NumLevels),
920+
}, slices.Collect(m.LevelMetricsIter())...)
917921
cur.Offset(-1, 0).WriteString("total")
918922

919923
cur = cur.NewlineReturn()

‎testdata/compaction/l0_to_lbase_compaction‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ level size | tables size | count size | refsz valblk | in | tables
4343
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
4444
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
4545
6 6MB | 3 6MB | 0 0 | 0B 0B | 0B | 0 0B | 1 0
46+
-----------------+--------------+--------------+---------------+--------+--------------+----------
4647
total 6MB | 3 6MB | 0 0 | 0B 0B | 4.5MB | 0 0B | 1 2.32
4748

4849
COMPACTIONS | moved | multilevel | read | written
@@ -55,6 +56,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
5556
4 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
5657
5 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
5758
6 | - 0.09 0.09 | 3 6MB | 0B 0B 0B | 0B 0B | 0 0B 0B
59+
------+-------------------+--------------+-------------------+--------------+---------------------
5860
total | - - - | 3 6MB | 0B 0B 0B | 0B 0B | 3 10MB 0B
5961

6062
kind | default delete elision move read tomb rewrite copy multi blob

‎testdata/compaction/value_separation‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ level size | tables size | count size | refsz valblk | in | tables
131131
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
132132
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
133133
6 916B | 1 804B | 0 0 | 112B 0B | 753B | 0 0B | 1 1.22
134+
-----------------+--------------+--------------+---------------+--------+--------------+----------
134135
total 916B | 1 804B | 0 0 | 112B 0B | 41B | 0 0B | 1 46.59
135136

136137
COMPACTIONS | moved | multilevel | read | written
@@ -143,6 +144,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
143144
4 | - 0 0 | 1 753B | 0B 0B 0B | 0B 0B | 0 0B 0B
144145
5 | - 0 0 | 1 753B | 0B 0B 0B | 0B 0B | 0 0B 0B
145146
6 | - 0.00 0.00 | 0 0B | 0B 0B 0B | 372B 84B | 1 804B 112B
147+
------+-------------------+--------------+-------------------+--------------+---------------------
146148
total | - - - | 5 3.7KB | 0B 0B 0B | 372B 84B | 2 1.6KB 312B
147149

148150
kind | default delete elision move read tomb rewrite copy multi blob
@@ -407,6 +409,7 @@ level size | tables size | count size | refsz valblk | in | tables
407409
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
408410
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
409411
6 1KB | 1 805B | 0 0 | 232B 0B | 1.5KB | 0 0B | 1 0.51
412+
-----------------+--------------+--------------+---------------+--------+--------------+----------
410413
total 1KB | 1 805B | 0 0 | 232B 0B | 156B | 0 0B | 1 19.49
411414

412415
COMPACTIONS | moved | multilevel | read | written
@@ -419,6 +422,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
419422
4 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
420423
5 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
421424
6 | - 0.00 0.00 | 0 0B | 0B 0B 0B | 310B 0B | 1 805B 0B
425+
------+-------------------+--------------+-------------------+--------------+---------------------
422426
total | - - - | 0 0B | 0B 0B 0B | 310B 0B | 3 2.5KB 502B
423427

424428
kind | default delete elision move read tomb rewrite copy multi blob

‎testdata/event_listener‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ level size | tables size | count size | refsz valblk | in | tables
268268
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
269269
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
270270
6 652B | 1 652B | 0 0 | 0B 0B | 1.3KB | 0 0B | 1 0.50
271+
-----------------+--------------+--------------+---------------+--------+--------------+----------
271272
total 1.9KB | 3 1.9KB | 0 0 | 0B 0B | 749B | 1 652B | 3 4.50
272273

273274
COMPACTIONS | moved | multilevel | read | written
@@ -280,6 +281,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
280281
4 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
281282
5 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
282283
6 | - 0.00 0.00 | 0 0B | 0B 0B 0B | 1.1KB 0B | 1 652B 0B
284+
------+-------------------+--------------+-------------------+--------------+---------------------
283285
total | - - - | 0 0B | 0B 0B 0B | 1.1KB 0B | 4 3.3KB 0B
284286

285287
kind | default delete elision move read tomb rewrite copy multi blob
@@ -409,6 +411,7 @@ level size | tables size | count size | refsz valblk | in | tables
409411
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
410412
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
411413
6 1.3KB | 2 1.3KB | 0 0 | 0B 0B | 1.3KB | 1 652B | 1 0.50
414+
-----------------+--------------+--------------+---------------+--------+--------------+----------
412415
total 3.8KB | 6 3.8KB | 0 0 | 0B 0B | 2KB | 3 1.9KB | 5 2.57
413416

414417
COMPACTIONS | moved | multilevel | read | written
@@ -421,6 +424,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
421424
4 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
422425
5 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
423426
6 | - 0.00 0.00 | 0 0B | 0B 0B 0B | 1.1KB 0B | 1 652B 0B
427+
------+-------------------+--------------+-------------------+--------------+---------------------
424428
total | - - - | 0 0B | 0B 0B 0B | 1.1KB 0B | 5 5.2KB 0B
425429

426430
kind | default delete elision move read tomb rewrite copy multi blob

‎testdata/ingest‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ level size | tables size | count size | refsz valblk | in | tables
4242
4 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
4343
5 0B | 0 0B | 0 0 | 0B 0B | 0B | 0 0B | 0 0
4444
6 463B | 1 463B | 0 0 | 0B 0B | 0B | 1 463B | 1 0
45+
-----------------+--------------+--------------+---------------+--------+--------------+----------
4546
total 463B | 1 463B | 0 0 | 0B 0B | 463B | 1 463B | 1 1.00
4647

4748
COMPACTIONS | moved | multilevel | read | written
@@ -54,6 +55,7 @@ level | score ff cff | tables size | top in read | tables blob | ta
5455
4 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
5556
5 | - 0 0 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
5657
6 | - 0.00 0.00 | 0 0B | 0B 0B 0B | 0B 0B | 0 0B 0B
58+
------+-------------------+--------------+-------------------+--------------+---------------------
5759
total | - - - | 0 0B | 0B 0B 0B | 0B 0B | 0 463B 0B
5860

5961
kind | default delete elision move read tomb rewrite copy multi blob

0 commit comments

Comments
 (0)