db: move compression profile reexports to sstable

Profiles apply to individual sstables, not an entire database. We will
introduce db-wide compression settings; the existing
CompressionProfile aliases in pebble will lead to confusion.

This commit moves the aliases to sstable.

Author: RaduBerinde

checkpoint_test.go

@@ -19,6 +19,7 @@ import (
 	"github.com/cockroachdb/datadriven"
 	"github.com/cockroachdb/pebble/internal/base"
 	"github.com/cockroachdb/pebble/objstorage/remote"
+	"github.com/cockroachdb/pebble/sstable"
 	"github.com/cockroachdb/pebble/vfs"
 	"github.com/stretchr/testify/require"
 )
@@ -434,7 +435,7 @@ func TestCheckpointManyFiles(t *testing.T) {
 	// Disable compression to speed up the test.
 	opts.EnsureDefaults()
 	for i := range opts.Levels {
-		opts.Levels[i].Compression = func() *CompressionProfile { return NoCompression }
+		opts.Levels[i].Compression = func() *sstable.CompressionProfile { return sstable.NoCompression }
 	}
 
 	d, err := Open("", opts)

ingest_test.go

@@ -2957,7 +2957,7 @@ func TestIngestValidation(t *testing.T) {
 				w := sstable.NewWriter(objstorageprovider.NewFileWritable(f), sstable.WriterOptions{
 					BlockSize:   blockSize, // Create many smaller blocks.
 					Comparer:    opts.Comparer,
-					Compression: NoCompression, // For simpler debugging.
+					Compression: sstable.NoCompression, // For simpler debugging.
 					KeySchema:   opts.KeySchemas[opts.KeySchema],
 				})
 				for _, kv := range keyVals {

level_iter_test.go

@@ -530,7 +530,7 @@ func buildLevelIterTables(
 		writers[i] = sstable.NewRawWriter(objstorageprovider.NewFileWritable(files[i]), sstable.WriterOptions{
 			BlockRestartInterval: restartInterval,
 			BlockSize:            blockSize,
-			Compression:          NoCompression,
+			Compression:          sstable.NoCompression,
 		})
 	}
 

merging_iter_test.go

@@ -350,7 +350,7 @@ func buildMergingIterTables(
 		writers[i] = sstable.NewRawWriter(objstorageprovider.NewFileWritable(files[i]), sstable.WriterOptions{
 			BlockRestartInterval: restartInterval,
 			BlockSize:            blockSize,
-			Compression:          NoCompression,
+			Compression:          sstable.NoCompression,
 		})
 	}
 
@@ -567,7 +567,7 @@ func buildLevelsForMergingIterSeqSeek(
 			writerOptions := sstable.WriterOptions{
 				BlockRestartInterval: restartInterval,
 				BlockSize:            blockSize,
-				Compression:          NoCompression,
+				Compression:          sstable.NoCompression,
 			}
 			if writeBloomFilters {
 				writerOptions.FilterPolicy = filterPolicy

metamorphic/options.go

@@ -801,13 +801,13 @@ func RandomOptions(
 
 	switch rng.IntN(4) {
 	case 0:
-		lopts.Compression = func() *block.CompressionProfile { return pebble.NoCompression }
+		lopts.Compression = func() *block.CompressionProfile { return sstable.NoCompression }
 	case 1:
-		lopts.Compression = func() *block.CompressionProfile { return pebble.ZstdCompression }
+		lopts.Compression = func() *block.CompressionProfile { return sstable.ZstdCompression }
 	case 2:
-		lopts.Compression = func() *block.CompressionProfile { return pebble.SnappyCompression }
+		lopts.Compression = func() *block.CompressionProfile { return sstable.SnappyCompression }
 	default:
-		lopts.Compression = func() *block.CompressionProfile { return pebble.MinLZCompression }
+		lopts.Compression = func() *block.CompressionProfile { return sstable.MinLZCompression }
 	}
 	opts.Levels[0] = lopts
 

options.go

@@ -41,20 +41,6 @@ const (
 	defaultLevelMultiplier = 10
 )
 
-type CompressionProfile = block.CompressionProfile
-
-// Exported Compression constants.
-var (
-	DefaultCompression = block.DefaultCompression
-	NoCompression      = block.NoCompression
-	SnappyCompression  = block.SnappyCompression
-	ZstdCompression    = block.ZstdCompression
-	// MinLZCompression is only supported with table formats v6+. Older formats
-	// fall back to snappy.
-	MinLZCompression   = block.MinLZCompression
-	FastestCompression = block.FastestCompression
-)
-
 // FilterType exports the base.FilterType type.
 type FilterType = base.FilterType
 
@@ -419,7 +405,7 @@ type LevelOptions struct {
 	//
 	// The default value is Snappy for L0, or the function from the previous level
 	// for all other levels.
-	Compression func() *CompressionProfile
+	Compression func() *sstable.CompressionProfile
 
 	// FilterPolicy defines a filter algorithm (such as a Bloom filter) that can
 	// reduce disk reads for Get calls.
@@ -467,7 +453,7 @@ func (o *LevelOptions) EnsureL0Defaults() {
 		o.BlockSizeThreshold = base.DefaultBlockSizeThreshold
 	}
 	if o.Compression == nil {
-		o.Compression = func() *CompressionProfile { return SnappyCompression }
+		o.Compression = func() *sstable.CompressionProfile { return sstable.SnappyCompression }
 	}
 	if o.FilterPolicy == nil {
 		o.FilterPolicy = NoFilterPolicy
@@ -2115,7 +2101,7 @@ func (o *Options) Parse(s string, hooks *ParseHooks) error {
 				if profile == nil {
 					return errors.Errorf("pebble: unknown compression: %q", errors.Safe(value))
 				}
-				l.Compression = func() *CompressionProfile { return profile }
+				l.Compression = func() *sstable.CompressionProfile { return profile }
 			case "filter_policy":
 				if hooks != nil && hooks.NewFilterPolicy != nil {
 					l.FilterPolicy, err = hooks.NewFilterPolicy(value)

sstable/options.go

@@ -128,6 +128,20 @@ func (o ReaderOptions) ensureDefaults() ReaderOptions {
 var defaultKeySchema = colblk.DefaultKeySchema(base.DefaultComparer, 16)
 var defaultKeySchemas = MakeKeySchemas(&defaultKeySchema)
 
+type CompressionProfile = block.CompressionProfile
+
+// Exported CompressionProfile constants.
+var (
+	DefaultCompression = block.DefaultCompression
+	NoCompression      = block.NoCompression
+	SnappyCompression  = block.SnappyCompression
+	ZstdCompression    = block.ZstdCompression
+	// MinLZCompression is only supported with table formats v6+. Older formats
+	// fall back to snappy.
+	MinLZCompression   = block.MinLZCompression
+	FastestCompression = block.FastestCompression
+)
+
 // WriterOptions holds the parameters used to control building an sstable.
 type WriterOptions struct {
 	// BlockRestartInterval is the number of keys between restart points
@@ -166,7 +180,7 @@ type WriterOptions struct {
 	// Compression defines the per-block compression to use.
 	//
 	// The default value uses snappy compression.
-	Compression *block.CompressionProfile
+	Compression *CompressionProfile
 
 	// FilterPolicy defines a filter algorithm (such as a Bloom filter) that can
 	// reduce disk reads for Get calls.
@@ -353,7 +367,7 @@ func (o WriterOptions) ensureDefaults() WriterOptions {
 	return o
 }
 
-func tableFormatSupportsCompressionProfile(tf TableFormat, profile *block.CompressionProfile) bool {
+func tableFormatSupportsCompressionProfile(tf TableFormat, profile *CompressionProfile) bool {
 	// MinLZ is only supported in TableFormatPebblev6 and higher.
 	if tf < TableFormatPebblev6 && profile.UsesMinLZ() {
 		return false

table_stats.go

@@ -1131,13 +1131,13 @@ func (a compressionTypeAggregator) Accumulate(
 	f *manifest.TableMetadata, dst *compressionTypes,
 ) (v *compressionTypes, cacheOK bool) {
 	switch f.Stats.CompressionType {
-	case SnappyCompression:
+	case sstable.SnappyCompression:
 		dst.snappy++
-	case ZstdCompression:
+	case sstable.ZstdCompression:
 		dst.zstd++
-	case MinLZCompression:
+	case sstable.MinLZCompression:
 		dst.minlz++
-	case NoCompression:
+	case sstable.NoCompression:
 		dst.none++
 	default:
 		dst.unknown++