Skip to content

Commit b6e27cd

Browse files
committed
pebble: remove unused param in incrementCompactions fn
1 parent 209a45f commit b6e27cd

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

compaction.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1816,8 +1816,7 @@ func (d *DB) flush1() (bytesFlushed uint64, err error) {
18161816

18171817
d.clearCompactingState(c, err != nil)
18181818
delete(d.mu.compact.inProgress, c)
1819-
d.mu.versions.incrementCompactions(c.kind, c.extraLevels, c.metrics.picker,
1820-
c.metrics.bytesWritten.Load(), err)
1819+
d.mu.versions.incrementCompactions(c.kind, c.extraLevels, c.metrics.bytesWritten.Load(), err)
18211820

18221821
var flushed flushableList
18231822
if err == nil {
@@ -2726,8 +2725,7 @@ func (d *DB) compact1(jobID JobID, c *tableCompaction) (err error) {
27262725
// NB: clearing compacting state must occur before updating the read state;
27272726
// L0Sublevels initialization depends on it.
27282727
d.clearCompactingState(c, err != nil)
2729-
d.mu.versions.incrementCompactions(c.kind, c.extraLevels, c.metrics.picker,
2730-
c.metrics.bytesWritten.Load(), err)
2728+
d.mu.versions.incrementCompactions(c.kind, c.extraLevels, c.metrics.bytesWritten.Load(), err)
27312729
d.mu.versions.incrementCompactionBytes(-c.metrics.bytesWritten.Load())
27322730

27332731
info.TotalDuration = d.timeNow().Sub(c.metrics.beganAt)

version_set.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -939,11 +939,7 @@ func sizeIfLocal(
939939
}
940940

941941
func (vs *versionSet) incrementCompactions(
942-
kind compactionKind,
943-
extraLevels []*compactionLevel,
944-
pickerMetrics pickedCompactionMetrics,
945-
bytesWritten int64,
946-
compactionErr error,
942+
kind compactionKind, extraLevels []*compactionLevel, bytesWritten int64, compactionErr error,
947943
) {
948944
if kind == compactionKindFlush || kind == compactionKindIngestedFlushable {
949945
vs.metrics.Flush.Count++

0 commit comments

Comments
 (0)