chore: rename named ssts

We use these ssts in our datadriven tool testing. In the
future, we will need to be able to parse the file number of such ssts
in order to properly collect each sst's blob reference.

Author: annrpom

internal/sstableinternal/options.go

@@ -12,8 +12,8 @@ import (
 // CacheOptions contains the information needed to interact with the block
 // cache.
 type CacheOptions struct {
-	// CacheHandle can be nil, in which case no cache is used. When non-nil, the other
-	// fields must be set accordingly.
+	// CacheHandle can be nil, in which case no cache is used. When non-nil, the
+	// other fields must be set accordingly.
 	CacheHandle *cache.Handle
 	FileNum     base.DiskFileNum
 }

sstable/compressionanalyzer/testdata/file_analyzer

@@ -1,5 +1,5 @@
 sst
-../testdata/h.sst
+../testdata/hamlet-sst/000002.sst
 ----
 Kind   Size Range  Test CR  Samples  Size                 Snappy      MinLZ1      MinLZ2      ZSTD1       ZSTD3       ZSTD5       ZSTD7
 data   <24KB       1.5-2.5  14       1.9KB ± 25%  CR      1.9 ± 5%    0.0 ± 0%    0.0 ± 0%    0.0 ± 0%    0.0 ± 0%    0.0 ± 0%    0.0 ± 0%

sstable/properties_test.go

@@ -44,7 +44,7 @@ func TestPropertiesLoad(t *testing.T) {
 
 	{
 		// Check that we can read properties from a table.
-		f, err := vfs.Default.Open(filepath.FromSlash("testdata/h.sst"))
+		f, err := vfs.Default.Open(filepath.FromSlash("testdata/hamlet-sst/000002.sst"))
 		require.NoError(t, err)
 
 		r, err := newReader(f, ReaderOptions{})

sstable/reader_test.go

@@ -1628,7 +1628,7 @@ func TestValidateBlockChecksums(t *testing.T) {
 		{
 			name: "top index block corruption",
 			files: []string{
-				"h.no-compression.two_level_index.sst",
+				"h-no-compression-two-level-index-sst/000003.sst",
 			},
 			corruptionLocations: []corruptionLocation{
 				corruptionLocationTopIndex,
@@ -1637,9 +1637,9 @@ func TestValidateBlockChecksums(t *testing.T) {
 		{
 			name: "filter block corruption",
 			files: []string{
-				"h.table-bloom.no-compression.prefix_extractor.no_whole_key_filter.sst",
-				"h.table-bloom.no-compression.sst",
-				"h.table-bloom.sst",
+				"h-table-bloom-no-compression-prefix-extractor-no-whole-key-filter-sst/000013.sst",
+				"h-table-bloom-no-compression-sst/000011.sst",
+				"h-table-bloom-sst/000010.sst",
 			},
 			corruptionLocations: []corruptionLocation{
 				corruptionLocationFilter,

sstable/table_test.go

@@ -250,17 +250,17 @@ func testReader(t *testing.T, filename string, comparer *Comparer, fp FilterPoli
 
 func TestReaderDefaultCompression(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	testReader(t, "h.sst", nil, nil)
+	testReader(t, "hamlet-sst/000002.sst", nil, nil)
 }
 
 func TestReaderNoCompression(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	testReader(t, "h.no-compression.sst", nil, nil)
+	testReader(t, "h-no-compression-sst/000012.sst", nil, nil)
 }
 
 func TestReaderTableBloom(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	testReader(t, "h.table-bloom.no-compression.sst", nil, nil)
+	testReader(t, "h-table-bloom-no-compression-sst/000011.sst", nil, nil)
 }
 
 func TestReaderBloomUsed(t *testing.T) {
@@ -283,8 +283,8 @@ func TestReaderBloomUsed(t *testing.T) {
 		path     string
 		comparer *Comparer
 	}{
-		{"h.table-bloom.no-compression.sst", nil},
-		{"h.table-bloom.no-compression.prefix_extractor.no_whole_key_filter.sst", fixtureComparer},
+		{"h-table-bloom-no-compression-sst/000011.sst", nil},
+		{"h-table-bloom-no-compression-prefix-extractor-no-whole-key-filter-sst/000013.sst", fixtureComparer},
 	}
 	for _, tc := range files {
 		t.Run(tc.path, func(t *testing.T) {
@@ -325,7 +325,7 @@ func TestReaderBloomUsed(t *testing.T) {
 
 func TestBloomFilterFalsePositiveRate(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	f, err := vfs.Default.Open(filepath.FromSlash("testdata/h.table-bloom.no-compression.sst"))
+	f, err := vfs.Default.Open(filepath.FromSlash("testdata/h-table-bloom-no-compression-sst/000011.sst"))
 	require.NoError(t, err)
 
 	c := &countingFilterPolicy{
@@ -500,7 +500,7 @@ func TestFinalBlockIsWritten(t *testing.T) {
 
 func TestReaderSymtheticSeqNum(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	f, err := vfs.Default.Open(filepath.FromSlash("testdata/h.sst"))
+	f, err := vfs.Default.Open(filepath.FromSlash("testdata/hamlet-sst/000002.sst"))
 	require.NoError(t, err)
 
 	r, err := newReader(f, ReaderOptions{})

sstable/test_fixtures.go

@@ -188,55 +188,55 @@ type TestFixtureInfo struct {
 // TestFixtures contains all metadata necessary to generate the test SSTs.
 var TestFixtures = []TestFixtureInfo{
 	{
-		Filename:           "h.sst",
+		Filename:           "hamlet-sst/000002.sst",
 		Compression:        block.SnappyCompression,
 		FullKeyFilter:      false,
 		PrefixFilter:       false,
 		IndexBlockSize:     fixtureDefaultIndexBlockSize,
 		UseFixtureComparer: false,
 	},
 	{
-		Filename:           "h.no-compression.sst",
+		Filename:           "h-no-compression-sst/000012.sst",
 		Compression:        block.NoCompression,
 		FullKeyFilter:      false,
 		PrefixFilter:       false,
 		IndexBlockSize:     fixtureDefaultIndexBlockSize,
 		UseFixtureComparer: false,
 	},
 	{
-		Filename:           "h.table-bloom.sst",
+		Filename:           "h-table-bloom-sst/000010.sst",
 		Compression:        block.SnappyCompression,
 		FullKeyFilter:      true,
 		PrefixFilter:       false,
 		IndexBlockSize:     fixtureDefaultIndexBlockSize,
 		UseFixtureComparer: false,
 	},
 	{
-		Filename:           "h.table-bloom.no-compression.sst",
+		Filename:           "h-table-bloom-no-compression-sst/000011.sst",
 		Compression:        block.NoCompression,
 		FullKeyFilter:      true,
 		PrefixFilter:       false,
 		IndexBlockSize:     fixtureDefaultIndexBlockSize,
 		UseFixtureComparer: false,
 	},
 	{
-		Filename:           "h.table-bloom.no-compression.prefix_extractor.no_whole_key_filter.sst",
+		Filename:           "h-table-bloom-no-compression-prefix-extractor-no-whole-key-filter-sst/000013.sst",
 		Compression:        block.NoCompression,
 		FullKeyFilter:      false,
 		PrefixFilter:       true,
 		IndexBlockSize:     fixtureDefaultIndexBlockSize,
 		UseFixtureComparer: true,
 	},
 	{
-		Filename:           "h.no-compression.two_level_index.sst",
+		Filename:           "h-no-compression-two-level-index-sst/000003.sst",
 		Compression:        block.NoCompression,
 		FullKeyFilter:      false,
 		PrefixFilter:       false,
 		IndexBlockSize:     fixtureSmallIndexBlockSize,
 		UseFixtureComparer: false,
 	},
 	{
-		Filename:           "h.zstd-compression.sst",
+		Filename:           "h-zstd-compression-sst/000004.sst",
 		Compression:        block.ZstdCompression,
 		FullKeyFilter:      false,
 		PrefixFilter:       false,