Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: TestLatestRefCounting is flaky #3043

Closed
jbowens opened this issue Nov 7, 2023 · 0 comments · Fixed by #3133
Closed

db: TestLatestRefCounting is flaky #3043

jbowens opened this issue Nov 7, 2023 · 0 comments · Fixed by #3133
Assignees
@RaduBerinde
Labels
A-storage skipped-test T-storage

Comments

@jbowens
Copy link
Collaborator

jbowens commented Nov 7, 2023 

go test -run TestLatestRefCounting -exec 'stress -p 16'

--- FAIL: TestLatestRefCounting (0.00s)
    version_set_test.go:228:
        	Error Trace:	/Users/jackson/go/src/github.com/cockroachdb/pebble/version_set_test.go:228
        	Error:      	Not equal:
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestLatestRefCounting
FAIL


ERROR: exit status 1

362 runs completed, 1 failures, over 1s
context canceled
FAIL
exit status 1
FAIL	github.com/cockroachdb/pebble	0.864s
@itsbilal itsbilal self-assigned this Nov 29, 2023
@RaduBerinde RaduBerinde assigned RaduBerinde and unassigned itsbilal Dec 7, 2023
RaduBerinde added a commit to RaduBerinde/pebble that referenced this issue Dec 7, 2023
@RaduBerinde
db: fix flaky TestLatestRefCounting
7748989 
This check is racy in both directions:
 - we can check "too early", in that an asynchronous
   `collectTableStats` might still be holding a reference
 - we can check "too late", in that cleanup of the obsolete table has
   already happened

Since object cleanup is not the main point of this test, this commit
removes this check altogether.

Fixes cockroachdb#3043
@RaduBerinde RaduBerinde mentioned this issue Dec 7, 2023
Merged
RaduBerinde added a commit that referenced this issue Dec 7, 2023
@RaduBerinde
db: fix flaky TestLatestRefCounting
dbeb058 
This check is racy in both directions:
 - we can check "too early", in that an asynchronous
   `collectTableStats` might still be holding a reference
 - we can check "too late", in that cleanup of the obsolete table has
   already happened

Since object cleanup is not the main point of this test, this commit
removes this check altogether.

Fixes #3043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
A-storage skipped-test T-storage
Projects
Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db: fix flaky TestLatestRefCounting RaduBerinde/pebble
3 participants
@itsbilal @jbowens @RaduBerinde