Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: doc comments #66

Closed
8 tasks done
petermattis opened this issue Apr 5, 2019 · 1 comment
Closed
8 tasks done

*: doc comments #66

petermattis opened this issue Apr 5, 2019 · 1 comment
Assignees
@petermattis

Comments

@petermattis
Copy link
Collaborator

petermattis commented Apr 5, 2019 •
edited
Loading

There are various areas of the code which need further commentary to explain the implementation:

  • Batch: full indexing support (including merge and delete-range)
  • Batch: large (flushable) batches
  • Batch: commit pipeline
  • Cache: weak handles
  • Delete range: fragmentation, batches, compaction, get, iterator, ingestion
  • Memtable: max size (see flushable batches)
  • Memtable: reverse iteration
  • Table ingestion
@petermattis petermattis self-assigned this Apr 5, 2019
petermattis added a commit that referenced this issue Apr 22, 2019
@petermattis
Batch doc comments
cf96d12 
Batch indexing, atomic commits, large batches, and the batch internal
representation.

See #66
petermattis added a commit that referenced this issue Apr 22, 2019
@petermattis
memTable doc comments
99f1e64 
Update the memTable doc comments. Touch on the memTable memory usage,
the append-only nature, and how batches are prepared serially and then
applied concurrently.

See #66
petermattis added a commit that referenced this issue Apr 22, 2019
@petermattis
Batch doc comments
bda125b 
Batch indexing, atomic commits, large batches, and the batch internal
representation.

See #66
petermattis added a commit that referenced this issue Apr 22, 2019
@petermattis
memTable doc comments
1dccfad 
Update the memTable doc comments. Touch on the memTable memory usage,
the append-only nature, and how batches are prepared serially and then
applied concurrently.

See #66
petermattis added a commit that referenced this issue Apr 22, 2019
@petermattis
DB.Ingest doc comments
022caa9 
See #66
@petermattis
Copy link
Collaborator Author

While there are undoubtedly more doc comments to write, the ones listed above have all been taken care of (to greater and lesser degrees).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petermattis