-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: return *InternalKV from internal iterators #2958
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, internal iterators' positioning methods returned two return values, a pointer to an internal key and a LazyValue struct. This commit collapses these two return values into a single return value: a pointer to an InternalKV struct. The key and value buffers were already owned by the underlying iterator, so passing the base.LazyValue as a value did not decouple the two. Propagating a single *InternalKV pointer can be cheaper in some instnaces. More importantly, it allows us to propagate additional information without increasing the amount of copying up and down the iterator stack. I anticipate this being useful in the implementation of #111001. Merging this change now will reduce the pain of backports to 23.1. Iterator microbenchmarks show movement in both directions ± ~4%. ``` goos: linux goarch: amd64 pkg: github.com/cockroachdb/pebble cpu: Intel(R) Xeon(R) CPU @ 2.80GHz │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ IteratorSeekGE-24 714.6n ± 2% 747.1n ± 3% +4.54% (p=0.000 n=10) IteratorNext-24 26.18n ± 0% 25.53n ± 0% -2.50% (p=0.000 n=10) IteratorPrev-24 35.49n ± 0% 36.48n ± 1% +2.78% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=false/bloom=false/with-tombstone=false-24 503.8n ± 0% 497.8n ± 0% -1.18% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=false/bloom=false/with-tombstone=true-24 388.8n ± 0% 384.8n ± 0% -1.02% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=false/bloom=true/with-tombstone=false-24 1.070µ ± 0% 1.082µ ± 0% +1.17% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=false/bloom=true/with-tombstone=true-24 465.7n ± 1% 467.9n ± 1% +0.48% (p=0.009 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=true/bloom=false/with-tombstone=false-24 582.6n ± 0% 559.3n ± 0% -4.00% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=true/bloom=false/with-tombstone=true-24 403.8n ± 0% 399.6n ± 0% -1.03% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=true/bloom=true/with-tombstone=false-24 1.093µ ± 0% 1.103µ ± 1% +0.87% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=1/two-level=true/bloom=true/with-tombstone=true-24 464.9n ± 1% 471.7n ± 0% +1.46% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=false/bloom=false/with-tombstone=false-24 503.7n ± 0% 497.9n ± 0% -1.15% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=false/bloom=false/with-tombstone=true-24 389.1n ± 0% 384.4n ± 0% -1.21% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=false/bloom=true/with-tombstone=false-24 1.068µ ± 1% 1.085µ ± 1% +1.54% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=false/bloom=true/with-tombstone=true-24 463.1n ± 1% 463.9n ± 1% ~ (p=0.631 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=true/bloom=false/with-tombstone=false-24 583.0n ± 0% 559.1n ± 0% -4.08% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=true/bloom=false/with-tombstone=true-24 403.4n ± 0% 399.6n ± 0% -0.94% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=true/bloom=true/with-tombstone=false-24 1.094µ ± 1% 1.103µ ± 0% +0.82% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=2/two-level=true/bloom=true/with-tombstone=true-24 463.2n ± 1% 462.9n ± 0% ~ (p=0.305 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=false/bloom=false/with-tombstone=false-24 504.9n ± 0% 498.9n ± 0% -1.19% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=false/bloom=false/with-tombstone=true-24 389.6n ± 0% 385.6n ± 0% -1.03% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=false/bloom=true/with-tombstone=false-24 1.060µ ± 0% 1.065µ ± 0% +0.42% (p=0.012 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=false/bloom=true/with-tombstone=true-24 461.8n ± 0% 460.2n ± 0% -0.36% (p=0.041 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=true/bloom=false/with-tombstone=false-24 584.1n ± 0% 560.3n ± 0% -4.08% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=true/bloom=false/with-tombstone=true-24 404.3n ± 0% 400.7n ± 0% -0.90% (p=0.000 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=true/bloom=true/with-tombstone=false-24 1.085µ ± 0% 1.090µ ± 1% +0.46% (p=0.003 n=10) IteratorSeqSeekPrefixGENotFound/skip=4/two-level=true/bloom=true/with-tombstone=true-24 463.4n ± 0% 462.0n ± 1% ~ (p=0.255 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=false/bloom=false/with-tombstone=false-24 605.7n ± 0% 593.3n ± 0% -2.03% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=false/bloom=false/with-tombstone=true-24 489.3n ± 0% 483.3n ± 0% -1.24% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=false/bloom=true/with-tombstone=false-24 1.269µ ± 0% 1.243µ ± 1% -2.01% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=false/bloom=true/with-tombstone=true-24 755.5n ± 0% 742.8n ± 0% -1.69% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=true/bloom=false/with-tombstone=false-24 683.7n ± 0% 663.3n ± 0% -2.98% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=true/bloom=false/with-tombstone=true-24 508.2n ± 0% 498.3n ± 0% -1.94% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=true/bloom=true/with-tombstone=false-24 1.268µ ± 0% 1.238µ ± 1% -2.41% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=1/two-level=true/bloom=true/with-tombstone=true-24 776.4n ± 0% 754.6n ± 1% -2.81% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=false/bloom=false/with-tombstone=false-24 641.5n ± 0% 629.6n ± 0% -1.86% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=false/bloom=false/with-tombstone=true-24 521.8n ± 0% 514.2n ± 0% -1.46% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=false/bloom=true/with-tombstone=false-24 1.302µ ± 0% 1.282µ ± 0% -1.57% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=false/bloom=true/with-tombstone=true-24 783.1n ± 0% 767.3n ± 0% -2.02% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=true/bloom=false/with-tombstone=false-24 721.1n ± 0% 700.3n ± 0% -2.88% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=true/bloom=false/with-tombstone=true-24 540.3n ± 0% 529.8n ± 0% -1.93% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=true/bloom=true/with-tombstone=false-24 1.305µ ± 0% 1.272µ ± 0% -2.53% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=2/two-level=true/bloom=true/with-tombstone=true-24 803.2n ± 0% 779.1n ± 1% -3.00% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=false/bloom=false/with-tombstone=false-24 709.9n ± 0% 694.5n ± 0% -2.16% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=false/bloom=false/with-tombstone=true-24 588.5n ± 0% 578.8n ± 0% -1.65% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=false/bloom=true/with-tombstone=false-24 1.377µ ± 0% 1.348µ ± 1% -2.07% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=false/bloom=true/with-tombstone=true-24 842.3n ± 0% 824.4n ± 1% -2.13% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=true/bloom=false/with-tombstone=false-24 791.5n ± 0% 768.2n ± 0% -2.94% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=true/bloom=false/with-tombstone=true-24 610.2n ± 0% 595.6n ± 0% -2.39% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=true/bloom=true/with-tombstone=false-24 1.377µ ± 0% 1.341µ ± 0% -2.58% (p=0.000 n=10) IteratorSeqSeekPrefixGEFound/skip=4/two-level=true/bloom=true/with-tombstone=true-24 861.5n ± 1% 841.1n ± 1% -2.37% (p=0.000 n=10) IteratorSeqSeekGEWithBounds/two-level=false-24 912.5n ± 1% 893.6n ± 1% -2.07% (p=0.000 n=10) IteratorSeqSeekGEWithBounds/two-level=true-24 911.4n ± 0% 893.6n ± 0% -1.95% (p=0.000 n=10) IteratorSeekGENoop/withLimit=false-24 45.12n ± 1% 50.98n ± 0% +12.98% (p=0.000 n=10) IteratorSeekGENoop/withLimit=true-24 82.73n ± 0% 89.69n ± 0% +8.41% (p=0.000 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@10/forward/seekprefix-24 45.07m ± 5% 44.94m ± 3% ~ (p=0.393 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@10/forward/next-24 4.023m ± 1% 3.974m ± 1% -1.23% (p=0.019 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@10/backward-24 4.877m ± 1% 4.843m ± 1% ~ (p=0.247 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@50/forward/seekprefix-24 44.63m ± 5% 44.79m ± 5% ~ (p=0.579 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@50/forward/next-24 3.584m ± 1% 3.546m ± 1% -1.04% (p=0.002 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@50/backward-24 4.188m ± 1% 4.213m ± 2% ~ (p=0.796 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@75/forward/seekprefix-24 44.41m ± 3% 45.65m ± 2% +2.79% (p=0.035 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@75/forward/next-24 2.109m ± 1% 2.115m ± 1% ~ (p=0.579 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@75/backward-24 2.700m ± 1% 2.744m ± 1% +1.64% (p=0.000 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@100/forward/seekprefix-24 43.51m ± 2% 44.56m ± 5% +2.40% (p=0.029 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@100/forward/next-24 323.5µ ± 0% 317.1µ ± 1% -2.00% (p=0.000 n=10) Iterator_RangeKeyMasking/range-keys-suffixes=@100/backward-24 621.6µ ± 1% 621.2µ ± 1% ~ (p=0.739 n=10) IteratorScan/keys=100,r-amp=1,key-types=points-only-24 9.158µ ± 2% 9.227µ ± 1% ~ (p=0.315 n=10) IteratorScan/keys=100,r-amp=1,key-types=points-and-ranges-24 9.680µ ± 20% 9.619µ ± 1% ~ (p=0.481 n=10) IteratorScan/keys=100,r-amp=3,key-types=points-only-24 16.13µ ± 5% 16.62µ ± 16% +3.06% (p=0.029 n=10) IteratorScan/keys=100,r-amp=3,key-types=points-and-ranges-24 16.54µ ± 42% 16.54µ ± 0% ~ (p=0.869 n=10) IteratorScan/keys=100,r-amp=7,key-types=points-only-24 23.16µ ± 8% 24.06µ ± 18% +3.92% (p=0.019 n=10) IteratorScan/keys=100,r-amp=7,key-types=points-and-ranges-24 23.68µ ± 1% 23.98µ ± 2% +1.29% (p=0.005 n=10) IteratorScan/keys=100,r-amp=10,key-types=points-only-24 28.10µ ± 1% 28.39µ ± 24% +1.05% (p=0.005 n=10) IteratorScan/keys=100,r-amp=10,key-types=points-and-ranges-24 28.68µ ± 23% 28.78µ ± 23% ~ (p=0.353 n=10) IteratorScan/keys=1000,r-amp=1,key-types=points-only-24 72.03µ ± 0% 72.78µ ± 1% +1.04% (p=0.002 n=10) IteratorScan/keys=1000,r-amp=1,key-types=points-and-ranges-24 75.56µ ± 0% 75.98µ ± 1% +0.56% (p=0.000 n=10) IteratorScan/keys=1000,r-amp=3,key-types=points-only-24 119.7µ ± 0% 121.9µ ± 0% +1.82% (p=0.000 n=10) IteratorScan/keys=1000,r-amp=3,key-types=points-and-ranges-24 123.8µ ± 0% 125.7µ ± 0% +1.54% (p=0.000 n=10) IteratorScan/keys=1000,r-amp=7,key-types=points-only-24 153.1µ ± 1% 155.0µ ± 0% +1.23% (p=0.002 n=10) IteratorScan/keys=1000,r-amp=7,key-types=points-and-ranges-24 156.8µ ± 1% 159.3µ ± 1% +1.55% (p=0.002 n=10) IteratorScan/keys=1000,r-amp=10,key-types=points-only-24 164.6µ ± 0% 167.6µ ± 0% +1.82% (p=0.000 n=10) IteratorScan/keys=1000,r-amp=10,key-types=points-and-ranges-24 169.3µ ± 1% 171.9µ ± 0% +1.51% (p=0.001 n=10) IteratorScan/keys=10000,r-amp=1,key-types=points-only-24 706.3µ ± 0% 717.6µ ± 4% +1.60% (p=0.001 n=10) IteratorScan/keys=10000,r-amp=1,key-types=points-and-ranges-24 739.2µ ± 1% 751.0µ ± 0% +1.59% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=3,key-types=points-only-24 1.155m ± 0% 1.180m ± 0% +2.15% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=3,key-types=points-and-ranges-24 1.195m ± 0% 1.219m ± 0% +2.01% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=7,key-types=points-only-24 1.441m ± 0% 1.467m ± 0% +1.76% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=7,key-types=points-and-ranges-24 1.481m ± 0% 1.507m ± 0% +1.80% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=10,key-types=points-only-24 1.526m ± 0% 1.569m ± 1% +2.79% (p=0.000 n=10) IteratorScan/keys=10000,r-amp=10,key-types=points-and-ranges-24 1.573m ± 0% 1.609m ± 1% +2.34% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=1/value-blocks=false/key-types=points-only-24 143.5n ± 0% 140.9n ± 0% -1.78% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=1/value-blocks=false/key-types=points-and-ranges-24 147.8n ± 0% 144.8n ± 0% -2.03% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=1/value-blocks=true/key-types=points-only-24 144.1n ± 0% 141.7n ± 0% -1.63% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=1/value-blocks=true/key-types=points-and-ranges-24 148.2n ± 0% 145.3n ± 0% -1.99% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=3/value-blocks=false/key-types=points-only-24 217.3n ± 0% 215.9n ± 0% -0.64% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=3/value-blocks=false/key-types=points-and-ranges-24 220.8n ± 0% 219.6n ± 0% -0.57% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=3/value-blocks=true/key-types=points-only-24 216.0n ± 0% 214.5n ± 0% -0.72% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=3/value-blocks=true/key-types=points-and-ranges-24 220.4n ± 0% 218.1n ± 0% -1.00% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=7/value-blocks=false/key-types=points-only-24 270.0n ± 0% 270.2n ± 0% ~ (p=0.146 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=7/value-blocks=false/key-types=points-and-ranges-24 274.1n ± 0% 275.1n ± 1% +0.36% (p=0.013 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=7/value-blocks=true/key-types=points-only-24 271.2n ± 0% 268.6n ± 0% -0.96% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=7/value-blocks=true/key-types=points-and-ranges-24 275.6n ± 0% 272.3n ± 0% -1.20% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=10/value-blocks=false/key-types=points-only-24 301.5n ± 0% 301.6n ± 0% ~ (p=0.322 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=10/value-blocks=false/key-types=points-and-ranges-24 306.2n ± 0% 305.2n ± 0% -0.36% (p=0.001 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=10/value-blocks=true/key-types=points-only-24 303.1n ± 0% 298.6n ± 0% -1.48% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=1/ramp=10/value-blocks=true/key-types=points-and-ranges-24 307.3n ± 0% 303.4n ± 0% -1.29% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=1/value-blocks=false/key-types=points-only-24 253.2n ± 0% 246.2n ± 0% -2.76% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=1/value-blocks=false/key-types=points-and-ranges-24 260.2n ± 0% 252.1n ± 0% -3.13% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=1/value-blocks=true/key-types=points-only-24 253.0n ± 0% 246.8n ± 0% -2.43% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=1/value-blocks=true/key-types=points-and-ranges-24 260.4n ± 0% 252.8n ± 0% -2.94% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=3/value-blocks=false/key-types=points-only-24 399.3n ± 0% 391.9n ± 0% -1.84% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=3/value-blocks=false/key-types=points-and-ranges-24 405.7n ± 0% 397.5n ± 0% -2.01% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=3/value-blocks=true/key-types=points-only-24 400.5n ± 0% 389.0n ± 0% -2.86% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=3/value-blocks=true/key-types=points-and-ranges-24 406.4n ± 0% 395.6n ± 0% -2.66% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=7/value-blocks=false/key-types=points-only-24 469.8n ± 0% 461.8n ± 0% -1.69% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=7/value-blocks=false/key-types=points-and-ranges-24 475.9n ± 0% 467.3n ± 0% -1.83% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=7/value-blocks=true/key-types=points-only-24 470.2n ± 0% 461.7n ± 0% -1.80% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=7/value-blocks=true/key-types=points-and-ranges-24 477.3n ± 0% 467.2n ± 0% -2.11% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=10/value-blocks=false/key-types=points-only-24 507.2n ± 0% 504.8n ± 0% -0.47% (p=0.017 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=10/value-blocks=false/key-types=points-and-ranges-24 513.4n ± 0% 513.0n ± 0% ~ (p=0.271 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=10/value-blocks=true/key-types=points-only-24 507.1n ± 0% 503.8n ± 0% -0.65% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=2/ramp=10/value-blocks=true/key-types=points-and-ranges-24 514.6n ± 0% 509.9n ± 0% -0.92% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=1/value-blocks=false/key-types=points-only-24 283.6n ± 0% 275.9n ± 0% -2.72% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=1/value-blocks=false/key-types=points-and-ranges-24 291.6n ± 0% 281.8n ± 0% -3.36% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=1/value-blocks=true/key-types=points-only-24 283.7n ± 1% 276.2n ± 0% -2.63% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=1/value-blocks=true/key-types=points-and-ranges-24 291.6n ± 0% 282.3n ± 0% -3.21% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=3/value-blocks=false/key-types=points-only-24 442.3n ± 0% 433.6n ± 0% -1.98% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=3/value-blocks=false/key-types=points-and-ranges-24 449.6n ± 0% 439.2n ± 0% -2.31% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=3/value-blocks=true/key-types=points-only-24 443.2n ± 0% 434.4n ± 0% -2.00% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=3/value-blocks=true/key-types=points-and-ranges-24 450.5n ± 0% 439.8n ± 0% -2.36% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=7/value-blocks=false/key-types=points-only-24 517.5n ± 0% 509.1n ± 1% -1.63% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=7/value-blocks=false/key-types=points-and-ranges-24 525.1n ± 0% 515.7n ± 0% -1.79% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=7/value-blocks=true/key-types=points-only-24 514.5n ± 0% 508.4n ± 0% -1.20% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=7/value-blocks=true/key-types=points-and-ranges-24 522.5n ± 0% 515.6n ± 0% -1.32% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=10/value-blocks=false/key-types=points-only-24 557.9n ± 0% 555.3n ± 0% -0.47% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=10/value-blocks=false/key-types=points-and-ranges-24 566.3n ± 0% 560.3n ± 0% -1.05% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=10/value-blocks=true/key-types=points-only-24 558.0n ± 0% 556.6n ± 0% -0.23% (p=0.027 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=10/ramp=10/value-blocks=true/key-types=points-and-ranges-24 566.5n ± 0% 562.4n ± 0% -0.73% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=1/value-blocks=false/key-types=points-only-24 616.8n ± 0% 608.5n ± 0% -1.34% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=1/value-blocks=false/key-types=points-and-ranges-24 620.8n ± 0% 614.1n ± 0% -1.08% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=1/value-blocks=true/key-types=points-only-24 615.5n ± 0% 606.4n ± 0% -1.49% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=1/value-blocks=true/key-types=points-and-ranges-24 619.9n ± 0% 613.0n ± 0% -1.11% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=3/value-blocks=false/key-types=points-only-24 851.4n ± 0% 843.9n ± 0% -0.88% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=3/value-blocks=false/key-types=points-and-ranges-24 856.5n ± 0% 850.0n ± 0% -0.76% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=3/value-blocks=true/key-types=points-only-24 852.7n ± 0% 843.0n ± 0% -1.14% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=3/value-blocks=true/key-types=points-and-ranges-24 857.7n ± 0% 849.7n ± 0% -0.93% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=7/value-blocks=false/key-types=points-only-24 963.4n ± 0% 958.7n ± 0% -0.48% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=7/value-blocks=false/key-types=points-and-ranges-24 969.5n ± 0% 961.8n ± 0% -0.80% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=7/value-blocks=true/key-types=points-only-24 967.0n ± 0% 956.9n ± 0% -1.04% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=7/value-blocks=true/key-types=points-and-ranges-24 972.6n ± 0% 963.3n ± 0% -0.96% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=10/value-blocks=false/key-types=points-only-24 1.042µ ± 0% 1.036µ ± 0% -0.62% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=10/value-blocks=false/key-types=points-and-ranges-24 1.048µ ± 0% 1.042µ ± 0% -0.62% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=10/value-blocks=true/key-types=points-only-24 1.040µ ± 0% 1.032µ ± 0% -0.82% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=10/versions=100/ramp=10/value-blocks=true/key-types=points-and-ranges-24 1.048µ ± 0% 1.040µ ± 0% -0.76% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=1/value-blocks=false/key-types=points-only-24 109.3n ± 0% 107.8n ± 0% -1.33% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=1/value-blocks=false/key-types=points-and-ranges-24 112.8n ± 0% 111.4n ± 0% -1.20% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=1/value-blocks=true/key-types=points-only-24 109.2n ± 0% 108.0n ± 0% -1.10% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=1/value-blocks=true/key-types=points-and-ranges-24 112.8n ± 0% 111.4n ± 0% -1.20% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=3/value-blocks=false/key-types=points-only-24 149.0n ± 0% 148.0n ± 0% -0.70% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=3/value-blocks=false/key-types=points-and-ranges-24 152.5n ± 0% 150.9n ± 0% -1.02% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=3/value-blocks=true/key-types=points-only-24 149.1n ± 0% 147.8n ± 0% -0.91% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=3/value-blocks=true/key-types=points-and-ranges-24 152.6n ± 0% 150.8n ± 0% -1.18% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=7/value-blocks=false/key-types=points-only-24 188.8n ± 1% 186.6n ± 0% -1.17% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=7/value-blocks=false/key-types=points-and-ranges-24 193.2n ± 0% 190.1n ± 0% -1.55% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=7/value-blocks=true/key-types=points-only-24 189.1n ± 0% 187.1n ± 0% -1.06% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=7/value-blocks=true/key-types=points-and-ranges-24 193.6n ± 0% 190.9n ± 1% -1.37% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=10/value-blocks=false/key-types=points-only-24 211.2n ± 0% 209.4n ± 0% -0.88% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=10/value-blocks=false/key-types=points-and-ranges-24 216.5n ± 0% 213.7n ± 0% -1.29% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=10/value-blocks=true/key-types=points-only-24 211.4n ± 0% 211.0n ± 0% -0.19% (p=0.021 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=1/ramp=10/value-blocks=true/key-types=points-and-ranges-24 216.5n ± 0% 214.7n ± 0% -0.83% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=1/value-blocks=false/key-types=points-only-24 208.5n ± 0% 201.5n ± 0% -3.36% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=1/value-blocks=false/key-types=points-and-ranges-24 215.1n ± 0% 207.2n ± 0% -3.67% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=1/value-blocks=true/key-types=points-only-24 208.5n ± 0% 201.3n ± 0% -3.48% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=1/value-blocks=true/key-types=points-and-ranges-24 214.6n ± 0% 207.2n ± 0% -3.43% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=3/value-blocks=false/key-types=points-only-24 305.2n ± 0% 297.6n ± 0% -2.49% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=3/value-blocks=false/key-types=points-and-ranges-24 312.4n ± 0% 303.2n ± 0% -2.94% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=3/value-blocks=true/key-types=points-only-24 305.8n ± 0% 298.8n ± 0% -2.26% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=3/value-blocks=true/key-types=points-and-ranges-24 312.4n ± 0% 304.6n ± 0% -2.48% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=7/value-blocks=false/key-types=points-only-24 359.8n ± 0% 353.6n ± 0% -1.71% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=7/value-blocks=false/key-types=points-and-ranges-24 366.6n ± 0% 360.4n ± 0% -1.68% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=7/value-blocks=true/key-types=points-only-24 358.8n ± 0% 353.5n ± 0% -1.48% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=7/value-blocks=true/key-types=points-and-ranges-24 365.8n ± 0% 359.9n ± 0% -1.61% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=10/value-blocks=false/key-types=points-only-24 386.0n ± 0% 384.2n ± 0% -0.45% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=10/value-blocks=false/key-types=points-and-ranges-24 393.9n ± 0% 390.1n ± 0% -0.95% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=10/value-blocks=true/key-types=points-only-24 385.6n ± 0% 384.9n ± 0% ~ (p=0.158 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=2/ramp=10/value-blocks=true/key-types=points-and-ranges-24 393.2n ± 0% 390.9n ± 0% -0.59% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=1/value-blocks=false/key-types=points-only-24 247.9n ± 0% 239.6n ± 0% -3.33% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=1/value-blocks=false/key-types=points-and-ranges-24 254.4n ± 0% 246.1n ± 0% -3.24% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=1/value-blocks=true/key-types=points-only-24 248.1n ± 0% 239.6n ± 0% -3.43% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=1/value-blocks=true/key-types=points-and-ranges-24 254.9n ± 0% 245.2n ± 0% -3.77% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=3/value-blocks=false/key-types=points-only-24 364.6n ± 0% 357.2n ± 0% -2.03% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=3/value-blocks=false/key-types=points-and-ranges-24 370.9n ± 0% 361.9n ± 0% -2.41% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=3/value-blocks=true/key-types=points-only-24 364.2n ± 0% 355.7n ± 0% -2.32% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=3/value-blocks=true/key-types=points-and-ranges-24 370.5n ± 0% 361.2n ± 0% -2.51% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=7/value-blocks=false/key-types=points-only-24 421.2n ± 0% 415.1n ± 0% -1.46% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=7/value-blocks=false/key-types=points-and-ranges-24 428.4n ± 0% 420.9n ± 0% -1.75% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=7/value-blocks=true/key-types=points-only-24 422.2n ± 0% 414.9n ± 0% -1.74% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=7/value-blocks=true/key-types=points-and-ranges-24 430.1n ± 0% 421.3n ± 0% -2.03% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=10/value-blocks=false/key-types=points-only-24 459.0n ± 0% 455.3n ± 0% -0.80% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=10/value-blocks=false/key-types=points-and-ranges-24 466.1n ± 0% 460.5n ± 0% -1.19% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=10/value-blocks=true/key-types=points-only-24 458.7n ± 0% 455.0n ± 0% -0.81% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=10/ramp=10/value-blocks=true/key-types=points-and-ranges-24 466.0n ± 0% 460.7n ± 0% -1.14% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=1/value-blocks=false/key-types=points-only-24 623.6n ± 0% 613.3n ± 0% -1.65% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=1/value-blocks=false/key-types=points-and-ranges-24 629.3n ± 0% 619.4n ± 0% -1.57% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=1/value-blocks=true/key-types=points-only-24 624.2n ± 0% 614.1n ± 0% -1.63% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=1/value-blocks=true/key-types=points-and-ranges-24 629.6n ± 0% 619.8n ± 0% -1.55% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=3/value-blocks=false/key-types=points-only-24 799.1n ± 0% 787.6n ± 1% -1.43% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=3/value-blocks=false/key-types=points-and-ranges-24 805.4n ± 0% 792.7n ± 0% -1.58% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=3/value-blocks=true/key-types=points-only-24 797.6n ± 0% 793.0n ± 0% -0.58% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=3/value-blocks=true/key-types=points-and-ranges-24 805.1n ± 0% 797.3n ± 0% -0.97% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=7/value-blocks=false/key-types=points-only-24 3.121µ ± 1% 2.999µ ± 0% -3.93% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=7/value-blocks=false/key-types=points-and-ranges-24 3.131µ ± 1% 3.012µ ± 0% -3.79% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=7/value-blocks=true/key-types=points-only-24 3.104µ ± 1% 2.988µ ± 1% -3.75% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=7/value-blocks=true/key-types=points-and-ranges-24 3.122µ ± 0% 3.011µ ± 0% -3.56% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=10/value-blocks=false/key-types=points-only-24 3.234µ ± 0% 3.106µ ± 1% -3.97% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=10/value-blocks=false/key-types=points-and-ranges-24 3.247µ ± 1% 3.114µ ± 1% -4.11% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=10/value-blocks=true/key-types=points-only-24 3.234µ ± 1% 3.099µ ± 0% -4.18% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=100/versions=100/ramp=10/value-blocks=true/key-types=points-and-ranges-24 3.250µ ± 0% 3.120µ ± 0% -4.00% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=1/value-blocks=false/key-types=points-only-24 109.0n ± 0% 108.2n ± 0% -0.69% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=1/value-blocks=false/key-types=points-and-ranges-24 112.5n ± 0% 111.5n ± 0% -0.89% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=1/value-blocks=true/key-types=points-only-24 109.5n ± 0% 107.8n ± 0% -1.46% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=1/value-blocks=true/key-types=points-and-ranges-24 112.9n ± 0% 111.3n ± 0% -1.42% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=3/value-blocks=false/key-types=points-only-24 134.8n ± 0% 135.2n ± 1% ~ (p=0.339 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=3/value-blocks=false/key-types=points-and-ranges-24 138.8n ± 0% 138.0n ± 0% -0.50% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=3/value-blocks=true/key-types=points-only-24 135.0n ± 0% 135.2n ± 1% ~ (p=0.360 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=3/value-blocks=true/key-types=points-and-ranges-24 138.8n ± 0% 137.6n ± 0% -0.83% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=7/value-blocks=false/key-types=points-only-24 175.9n ± 0% 174.0n ± 0% -1.05% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=7/value-blocks=false/key-types=points-and-ranges-24 180.6n ± 0% 177.6n ± 1% -1.63% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=7/value-blocks=true/key-types=points-only-24 176.0n ± 0% 174.4n ± 0% -0.94% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=7/value-blocks=true/key-types=points-and-ranges-24 180.2n ± 0% 177.8n ± 0% -1.36% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=10/value-blocks=false/key-types=points-only-24 200.5n ± 0% 198.8n ± 0% -0.90% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=10/value-blocks=false/key-types=points-and-ranges-24 205.4n ± 0% 202.8n ± 0% -1.29% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=10/value-blocks=true/key-types=points-only-24 200.8n ± 0% 199.2n ± 0% -0.82% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=1/ramp=10/value-blocks=true/key-types=points-and-ranges-24 205.3n ± 0% 203.3n ± 0% -0.97% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=2/ramp=1/value-blocks=false/key-types=points-only-24 209.1n ± 0% 201.9n ± 0% -3.44% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=2/ramp=1/value-blocks=false/key-types=points-and-ranges-24 215.6n ± 0% 207.4n ± 0% -3.80% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=2/ramp=1/value-blocks=true/key-types=points-only-24 208.6n ± 0% 201.8n ± 0% -3.26% (p=0.000 n=10) IteratorScanNextPrefix/keysPerLevel=1000/versions=2/ramp=1/value-blocks=true/key-types=points-and-ranges-24 215.1n ± 0% 207.5n ± 0% -3.56% (p=0.000 n=10) ```
@sumeerbhola I decided to wait until after the branch cut to merge this. |
Gonna have to re-do this 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large, fundamental change to the iterator stack, so I'd like to give it plenty of discussion. I put the PR together ahead of time so that we could clearly see what it looks like, but I'm happy to discard it if we decide against it. Also, speaking of large PRs, this one is truly massive. However, it is purely mechanical, and almost all of it trivially so. The levelIter's
smallestBoundary
,largestBoundary
fields required maybe the least trivial changes.If we decide to move forward and it would ease review, I'm also happy to split it across multiple PRs using adapter types to bridge interface gaps.
Previously, internal iterators' positioning methods returned two return values, a pointer to an internal key and a LazyValue struct. This commit collapses these two return values into a single return value: a pointer to an InternalKV struct. The key and value buffers were already owned by the underlying iterator, so passing the base.LazyValue as a value did not decouple the two. Propagating a single *InternalKV pointer can be cheaper in some instnaces.
More importantly, it allows us to propagate additional information without increasing the amount of copying up and down the iterator stack. I anticipate this being useful in the implementation of cockroachdb/cockroach#111001, allowing us to propagate checksums alongside keys and values. Merging this change before the branch cut will reduce the pain of any backports.
Iterator microbenchmarks show movement in both directions, mostly ± ~4%.