internal/keyspan: support interleaving end keys #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @itsbilal and @jbowens)
internal/keyspan/interleaving_iter.go line 89 at r2 (raw file):
// InterleavedIter does not interleave synthetic markers for spans that do not // contain any keys. //
Do we need to add to this description to mention the new mode?
Instead of copying each field of InterleavingIterOpts onto the InterleavingIter, add the entire struct as a field of the InterleavingIter.
Adapt the InterleavingIter to support a mode that interleaves span end keys. Informs cockroachdb#2863.
jbowens
commented
Apr 22, 2024
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @itsbilal and @RaduBerinde)
internal/keyspan/interleaving_iter.go line 89 at r2 (raw file):
Previously, RaduBerinde wrote…
Do we need to add to this description to mention the new mode?
Good call, done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the InterleavingIter to support a mode that interleaves span end keys.
Informs #2863.