Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify logical-loop CLI code #117

Closed
bobvawter opened this issue Apr 26, 2022 · 0 comments · Fixed by #457
Closed

Unify logical-loop CLI code #117

bobvawter opened this issue Apr 26, 2022 · 0 comments · Fixed by #457

Comments

@bobvawter
Copy link
Member

There's a bit of duplication between the pg and mysql logical-replication CLI commands, related to configuring the logical.Config and whatnot. This would evolve better if we had an intermediate logical command that provided common flag configuration.
bobvawter added a commit that referenced this issue Sep 5, 2023
@bobvawter
cmd: Unify logical commands
2bd091a 
This change extracts the heavily-duplicated code in the fslogical, mylogical,
pglogical, and start commands into a common stdlogical package.

Notable changes:
- We can now test that the CLI flag binding code runs to completion.
- The binary buildinfo is logged on startup.
- The CDC server may run the diags server on a separate port.

Closes #117
@bobvawter bobvawter mentioned this issue Sep 5, 2023
Merged
bobvawter added a commit that referenced this issue Sep 5, 2023
@bobvawter
cmd: Unify logical commands
efab77a 
This change extracts the heavily-duplicated code in the fslogical, mylogical,
pglogical, and start commands into a common stdlogical package.

Notable changes:
- We can now test that the CLI flag binding code runs to completion.
- The binary buildinfo is logged on startup.
- The CDC server may run the diags server on a separate port.

Closes #117
bobvawter added a commit that referenced this issue Sep 7, 2023
@bobvawter
cmd: Unify logical commands
0166fa5 
This change extracts the heavily-duplicated code in the fslogical, mylogical,
pglogical, and start commands into a common stdlogical package.

Notable changes:
- We can now test that the CLI flag binding code runs to completion.
- The binary buildinfo is logged on startup.
- The CDC server may run the diags server on a separate port.

Closes #117
github-merge-queue bot pushed a commit that referenced this issue Sep 7, 2023
@bobvawter
cmd: Unify logical commands
e05b684 
This change extracts the heavily-duplicated code in the fslogical, mylogical,
pglogical, and start commands into a common stdlogical package.

Notable changes:
- We can now test that the CLI flag binding code runs to completion.
- The binary buildinfo is logged on startup.
- The CDC server may run the diags server on a separate port.

Closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: Unify logical commands cockroachdb/replicator
1 participant
@bobvawter