schemawatch: Improved PK query. #103
Conversation
This change makes the schema query work properly in cases where the primary key constraint isn't named "primary". It also adds some additional test cases to ensure that the revised query works correctly when there are secondary indexes on the table.
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 67.77% 68.00% +0.23%
==========================================
Files 40 40
Lines 2557 2557
==========================================
+ Hits 1733 1739 +6
+ Misses 673 668 -5
+ Partials 151 150 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @BramGruneir)
There was a problem hiding this comment.
approved.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @BramGruneir)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bobvawter)
This change makes the schema query work properly in cases where the primary key
constraint isn't named "primary". It also adds some additional test cases to
ensure that the revised query works correctly when there are secondary indexes
on the table.
This change is