Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #193 #196

Merged
merged 1 commit into from
Jul 29, 2022
Merged

fixing issue #193 #196

merged 1 commit into from
Jul 29, 2022

Conversation

sravotto
Copy link
Contributor

@sravotto sravotto commented Jul 28, 2022

re-adding the defaultConsistentPoint in the logical package.


This change is Reviewable

@sravotto sravotto requested a review from bobvawter July 28, 2022 19:52
Copy link
Member

@bobvawter bobvawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: w/ nits

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @sravotto)


internal/source/logical/loop.go line 48 at r1 (raw file):

	// the key used to persist the consistentPoint stamp.
	consistentPointKey string
	// default consistentPoint.

Redundant comment.


internal/source/logical/loop.go line 96 at r1 (raw file):

		return nil, err
	}
	if len(data) == 0 {

Restructure as

if len(data) == 0 && l.defaultConsistentPoint != "" {
  data = []byte(l.defaultConsistentPoint)
}
return l.dialect.UnmarshalStamp(data)

Copy link
Contributor Author

@sravotto sravotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @bobvawter)


internal/source/logical/loop.go line 48 at r1 (raw file):

Previously, bobvawter (Bob Vawter) wrote…

Redundant comment.

Done.


internal/source/logical/loop.go line 96 at r1 (raw file):

Previously, bobvawter (Bob Vawter) wrote…

Restructure as

if len(data) == 0 && l.defaultConsistentPoint != "" {
  data = []byte(l.defaultConsistentPoint)
}
return l.dialect.UnmarshalStamp(data)

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants