Various clean up tasks #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 17, 2022 16:44
I dropped the formatting dependencies from notest.js in the icons package as they were causing an error about dynamic importing.
Release should run on pushes to master and pull_requests from any branch.
Adding a condition to skip the release job if the pull_request is from a fork.
nathanstilwell
pushed a commit
that referenced
this pull request
Oct 20, 2022
* Dropped Rachel Wang from docs reviewers * Removing dependencies from no test message I dropped the formatting dependencies from notest.js in the icons package as they were causing an error about dynamic importing. * Removing inconsistent use of AUTHORS files * updating actions/checkout and actions/setup-node * workflow: Changing Release to run on push, pull_request Release should run on pushes to master and pull_requests from any branch. * workflows: Skip release if PR from fork Adding a condition to skip the release job if the pull_request is from a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things I've been meaning to get around to,
😢 Dropping Rachel Wang from the
/docsreviewers list (and removing my comment)🧹 Removing some unnecessary dev dependencies from icons package
📜 Removing AUTHORS files (because of inconsistent use)
🔩 Only run release workflow on push to master, or pull_request
🔩 Skip release workflow if pull request is from a fork 🍴