Skip to content

Commit 1500a7f

Browse files
authored
fix(3p-notice): include third party notices in maturin (#969)
* fix(3p-notice): include third party notices in maturin * fix: remove unnecessary dependency
1 parent 5e8101c commit 1500a7f

File tree

2 files changed

+27
-24
lines changed

2 files changed

+27
-24
lines changed

.github/workflows/release.yml

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,27 @@ jobs:
2424
name: Cargo.toml
2525
path: Cargo.toml
2626

27+
generate-3p-notices:
28+
runs-on: ubuntu-latest
29+
steps:
30+
- uses: actions/checkout@v4
31+
- name: Rust Cache
32+
uses: Swatinem/rust-cache@v2
33+
- name: Install Rust toolchain
34+
uses: dtolnay/rust-toolchain@stable
35+
- name: Install cargo-about
36+
run: cargo install --locked cargo-about
37+
- name: Generate THIRD_PARTY_NOTICES.html
38+
run: cargo about generate -o THIRD_PARTY_NOTICES.html about.hbs
39+
- name: Upload THIRD_PARTY_NOTICES.html artifact
40+
uses: actions/upload-artifact@v4
41+
with:
42+
name: THIRD_PARTY_NOTICES.html
43+
path: THIRD_PARTY_NOTICES.html
44+
2745
build:
2846
runs-on: ${{ matrix.platform.runner }}
29-
needs: [create-versioned-toml]
47+
needs: [create-versioned-toml, generate-3p-notices]
3048
strategy:
3149
matrix:
3250
platform:
@@ -40,6 +58,9 @@ jobs:
4058
- uses: actions/download-artifact@v4
4159
with:
4260
name: Cargo.toml
61+
- uses: actions/download-artifact@v4
62+
with:
63+
name: THIRD_PARTY_NOTICES.html
4364
- uses: actions/setup-python@v5
4465
with:
4566
python-version: 3.13
@@ -77,12 +98,15 @@ jobs:
7798

7899
sdist:
79100
runs-on: ubuntu-latest
80-
needs: [create-versioned-toml]
101+
needs: [create-versioned-toml, generate-3p-notices]
81102
steps:
82103
- uses: actions/checkout@v4
83104
- uses: actions/download-artifact@v4
84105
with:
85106
name: Cargo.toml
107+
- uses: actions/download-artifact@v4
108+
with:
109+
name: THIRD_PARTY_NOTICES.html
86110
- name: Build sdist
87111
uses: PyO3/maturin-action@v1
88112
with:
@@ -94,28 +118,6 @@ jobs:
94118
name: wheels-sdist
95119
path: dist
96120

97-
generate-3p-notices:
98-
runs-on: ubuntu-latest
99-
needs: [create-versioned-toml]
100-
steps:
101-
- uses: actions/checkout@v4
102-
- uses: actions/download-artifact@v4
103-
with:
104-
name: Cargo.toml
105-
- name: Rust Cache
106-
uses: Swatinem/rust-cache@v2
107-
- name: Install Rust toolchain
108-
uses: dtolnay/rust-toolchain@stable
109-
- name: Install cargo-about
110-
run: cargo install --locked cargo-about
111-
- name: Generate THIRD_PARTY_NOTICES.html
112-
run: cargo about generate -o THIRD_PARTY_NOTICES.html about.hbs
113-
- name: Upload THIRD_PARTY_NOTICES.html artifact
114-
uses: actions/upload-artifact@v4
115-
with:
116-
name: THIRD_PARTY_NOTICES.html
117-
path: THIRD_PARTY_NOTICES.html
118-
119121
release:
120122
name: Release
121123
runs-on: ubuntu-latest

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ bindings = "pyo3"
5757
python-source = "python"
5858
module-name = "cocoindex._engine"
5959
features = ["pyo3/extension-module"]
60+
include = ["THIRD_PARTY_NOTICES.html"]
6061

6162
[project.optional-dependencies]
6263
dev = ["pytest", "pytest-asyncio", "ruff", "mypy", "pre-commit"]

0 commit comments

Comments
 (0)