build: Allow building without mstpm #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclaudio
reviewed
Jul 25, 2024
joergroedel
reviewed
Jul 31, 2024
AdamCDunlap
force-pushed
the
build-without-mstpm
branch
from
7954871
to
20a9000
Compare
Remove the default dependency from "kernel" on mstpm so it can be compiled without it. Change the Makefile to specify mstpm as feature by default. This allows running FEATURES='""' make to not build the mstpm. To run unit tests without testing mstpm, use: FEATURES_TEST='""' SVSM_ARGS_TEST='--exclude libmstpm' make test Signed-off-by: Adam Dunlap <acdunlap@google.com>
AdamCDunlap
force-pushed
the
build-without-mstpm
branch
from
20a9000
to
f6da12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The svsm crate allows the libmstpm dependency to be optional, but since it's a default feature there's no actual way to use make to compile it that disables the feature. Add the necessary parts so that it can be compiled out. This allows running FEATURES='""' make to not build the mstpm.
If there's an existing or better way to do this, please let me know!