Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #16248: .wasm / .asm.js files are both downloaded on web platform #16679

Merged

Conversation

dumganhar
Copy link
Contributor

Re: #16248

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo January 10, 2024 08:41
@dumganhar dumganhar marked this pull request as draft January 10, 2024 08:45
Copy link

github-actions bot commented Jan 10, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -62383,11 +62383,11 @@
              * @zh 是否支持派发 EventHandheld
              */
             EVENT_HANDHELD = "EVENT_HANDHELD",
             /**
-             * @en Check whether Webassembly is supported at runtime. Generally, it needs to be checked when the constant `WASM_SUPPORT_MODE` is 2.
+             * @en Check whether Webassembly is supported at runtime. Generally, it needs to be checked when the constant `NATIVE_CODE_BUNDLE_MODE` is 2.
              * If it is not supported, you need to fallback to the Asm solution.
-             * @zh 运行时检测是否支持 Webassembly,一般在宏 `WASM_SUPPORT_MODE` 为 2 时需要检测,如果不支持,需要回滚到 Asm 方案
+             * @zh 运行时检测是否支持 Webassembly,一般在宏 `NATIVE_CODE_BUNDLE_MODE` 为 2 时需要检测,如果不支持,需要回滚到 Asm 方案
              */
             WASM = "WASM"
         }
         export enum _pal_system_info_enum_type_network_type__NetworkType {

@@ -21,13 +21,13 @@
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
*/
import { CULL_MESHOPT, WASM_SUPPORT_MODE } from 'internal:constants';
import { CULL_MESHOPT, NATIVE_CODE_BUNDLE_MODE } from 'internal:constants';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think WASM_SUPPORT_MODE is more meaningful than NATIVE_CODE_BUNDLE_MODE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.
If using asmjs, it's a normal js code. asmjs is not a wasm mode.

@minggo
Copy link
Contributor

minggo commented Jan 10, 2024

Please fix eslint error as possible.

@dumganhar dumganhar marked this pull request as ready for review January 11, 2024 07:25
@dumganhar dumganhar merged commit 75c6f6d into cocos:v3.8.3 Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] .wasm / .asm.js files are both downloaded on web platform
2 participants