-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #16248: .wasm / .asm.js files are both downloaded on web platform #16679
fixed #16248: .wasm / .asm.js files are both downloaded on web platform #16679
Conversation
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -62383,11 +62383,11 @@
* @zh 是否支持派发 EventHandheld
*/
EVENT_HANDHELD = "EVENT_HANDHELD",
/**
- * @en Check whether Webassembly is supported at runtime. Generally, it needs to be checked when the constant `WASM_SUPPORT_MODE` is 2.
+ * @en Check whether Webassembly is supported at runtime. Generally, it needs to be checked when the constant `NATIVE_CODE_BUNDLE_MODE` is 2.
* If it is not supported, you need to fallback to the Asm solution.
- * @zh 运行时检测是否支持 Webassembly,一般在宏 `WASM_SUPPORT_MODE` 为 2 时需要检测,如果不支持,需要回滚到 Asm 方案
+ * @zh 运行时检测是否支持 Webassembly,一般在宏 `NATIVE_CODE_BUNDLE_MODE` 为 2 时需要检测,如果不支持,需要回滚到 Asm 方案
*/
WASM = "WASM"
}
export enum _pal_system_info_enum_type_network_type__NetworkType {
|
@@ -21,13 +21,13 @@ | |||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
THE SOFTWARE. | |||
*/ | |||
import { CULL_MESHOPT, WASM_SUPPORT_MODE } from 'internal:constants'; | |||
import { CULL_MESHOPT, NATIVE_CODE_BUNDLE_MODE } from 'internal:constants'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think WASM_SUPPORT_MODE is more meaningful than NATIVE_CODE_BUNDLE_MODE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
If using asmjs, it's a normal js code. asmjs is not a wasm mode.
Please fix eslint error as possible. |
…ix/383-16248-wasm-asm-both-download-web
Re: #16248
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: