-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance test for handle.py / BinaryValue #3413
base: master
Are you sure you want to change the base?
Conversation
This test let us compare different implementation of handle.py, like using BinaryValue vs LogicArray
It's probably easier to gather performance metrics using pytest-benchmark and the test_binary_value.py in the pytest directory. |
The benchmark introduced by this PR is meant to be implementation independent. What alternative do we have (that would ideally not require a simulator to run)? |
Example benchmark code is here: https://github.com/cocotb/cocotb/blob/master/tests/benchmark.py It needs fixing (authentication settings) to actually export and make plots. |
Thanks, I have already been using this matrix multiplier benchmark for my BinaryValue vs LogicArray comparison. But I would also need to benchmark other aspects of the BinaryValue/LogicArray API, like what if a signal contains |
Feel free to add. I will try to figure out how to get plotting/authentication working. |
These tests are measuring how long it takes to read signals, read one specific bit, write signals in cocotb.
This is part of the "Replace BinaryValue with LogicArray" effort #3244, these tests will help us better compare different implementations and their pros/cons.
Example of output: