Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32: Added missing use for Values trait. Added missing tests for … #37

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@nreynis
Copy link
Contributor

nreynis commented Sep 10, 2019

…some traits usage.

@florianeckerstorfer

This comment has been minimized.

Copy link
Member

florianeckerstorfer commented Sep 11, 2019

Thanks, could you update from the latest master so that CI can run through.

…some traits usage.
@nreynis nreynis force-pushed the nreynis:fix/missing-traits branch from 6be86ee to afcca50 Sep 11, 2019
@nreynis

This comment has been minimized.

Copy link
Contributor Author

nreynis commented Sep 11, 2019

Your welcome.
I also rebased my other PR.

@florianeckerstorfer florianeckerstorfer merged commit 2fe9d7c into cocur:master Sep 12, 2019
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.