Allow Symfony 6 and resolve depreciations #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
feature/symfony6
branch
7 times, most recently
from
4bda1a1
to
f1ac25b
Compare
GromNaN
force-pushed
the
feature/symfony6
branch
from
f1ac25b
to
2411abf
Compare
florianeckerstorfer
requested changes
Dec 18, 2021
Co-authored-by: Florian Eckerstorfer <florian@eckerstorfer.net>
|
Good catch. There is issue with scrutinizer. Not sure if it is correctly configured. |
florianeckerstorfer
approved these changes
Dec 19, 2021
Closed
Ocramius
reviewed
Jan 14, 2022
| @@ -19,7 +19,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.0", | |||
| "php": ">=7.1", | |||
There was a problem hiding this comment.
Should probably be ^7.1 || ~8.0.0 || ~8.1.0
There was a problem hiding this comment.
Really? Isn't PHP 8.2 supposed to be compatible with PHP 8.1?
There was a problem hiding this comment.
PHP doesn't (can't) follow SemVer, but in general, the current range selector also allows for PHP 9, which is a problem.
^7.1 || ^8.0 is also acceptable, if you feel like you aren't worried about breakages in 8.2+
There was a problem hiding this comment.
I started a PR and would appreciate your input on this: #301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for maintaining this library. I work on a project that uses it and that needs to be upgraded to Symfony 6.0.
I had to make a lot of updates in order to have tests passing. Please tell me if you prefers separated pull requests, or anything that I should change.
symfony/simple-phpunitto get polyfills for PHPUnit versions.voidreturn type)Cocur\Slugify\Tests\Bridge\Symfony\CocurSlugifyExtensionTest, to solve an errorParseError: syntax error, unexpected token "static", expecting identifier