Fix role not passed through in PackDefinitionBuilder#addSyncTable #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-codaio
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Oh you'll need to bump the semantic version in package.json too. If this gets used in the coda repo, there's a mysterious bug that it makes the coda lint job slow if you update the SDK without it including a semantic version bump. Can just increment the prerelease version number.
However, you're immediately using this in the packs repo, and we don't allow releasing packs using prelease SDK versions. So we probably just want to release a new version of the SDK with this change right away.
oleg-codaio
force-pushed
the
osv-fix-role-not-passed-through-in-packdefinitionbuilder-addsynctable
branch
from
d5f48b7
to
9234812
Compare
oleg-codaio
deleted the
osv-fix-role-not-passed-through-in-packdefinitionbuilder-addsynctable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rolewas missing here - fixing up to make sure we pass through all parameters going forward.PTAL @coda/packs