Update SDK to support sibling acls #3041
Conversation
drew-codaio
requested review from
sam-codaio,
jonathan-codaio and
patrick-codaio
and removed request for
a team
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codahq/packs-sdk", | |||
| "version": "1.7.11", | |||
| "version": "1.7.12", | |||
There was a problem hiding this comment.
since you'll be releasing this immediately, this is fine, but for future reference, the ideal flow is to make this 1.7.12-prerelease.1 and then as a part of doing the release process, it gets to drop the prerelease.
There was a problem hiding this comment.
I'll update this
|
Another way I thought about doing this is that we could let a sync table schema have a But I think that could live side-by-side with this, so no objection from me. |
There was a problem hiding this comment.
Yeah we can't release this right away I think? Need to update coda to add support to recognize support for this and support backwards compatibility, then need to have a PR read to fast merge to update every pack that uses permissions? Unless we change the SDK to be backwards compatible.
schema.ts
Outdated
| * | ||
| * TODO(sam): Unhide this | ||
| * @hidden | ||
| */ | ||
| export interface Permission { | ||
| export interface DirectPermission { | ||
| permissionType: PermissionType.Direct; |
There was a problem hiding this comment.
Can we make this for now permissionType?: PermissionType.Direct?
Why not just make the SDK backwards compatible for now (Direct permissions can have no type there and we assume direct?) |
good point. |
drew-codaio
force-pushed
the
drew-csb-sdk-sibling-acls
branch
from
9fa5c21
to
4b5c403
Compare
drew-codaio
force-pushed
the
drew-csb-sdk-sibling-acls
branch
from
4b5c403
to
06b206e
Compare
| * @hidden | ||
| */ | ||
| export enum PermissionType { | ||
| Delegated = 'delegated', |
There was a problem hiding this comment.
Can you include some basic JSDoc describing what the delegated and direct mean, when to use them, etc?
drew-codaio
force-pushed
the
drew-csb-sdk-sibling-acls
branch
from
06b206e
to
a3f3498
Compare
drew-codaio
force-pushed
the
drew-csb-sdk-sibling-acls
branch
from
a3f3498
to
44584ba
Compare
|
Make sure to fast follow with |
My bad still trying to figure out how this whole ecosystem works with the sdk. Will be mindful going forward. Sam and I are working on the fast follow rn. |
|
No need to apologize, there's lots of unwritten best practices to navigate, just spreading awareness. |
Part of the work for sibling ACLs. Updating permissions to have a new delegated type.