Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new version #3048

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Release new version #3048

merged 2 commits into from
Aug 29, 2024

Conversation

sam-codaio
Copy link
Contributor

@sam-codaio sam-codaio commented Aug 29, 2024 •
edited
Loading

@sam-codaio sam-codaio requested a review from a team as a code owner August 29, 2024 16:41
@sam-codaio sam-codaio force-pushed the sloate-release-version branch 2 times, most recently from 3175fbe to b68153b Compare August 29, 2024 16:47
jonathan-codaio
jonathan-codaio approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@jonathan-codaio jonathan-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, CI is complaining that it needs make build for some reason. Should do it and see what changes before merging though, not sure what here would be affected by the build.

@sam-codaio sam-codaio merged commit 2cfa187 into main Aug 29, 2024
1 check passed
@sam-codaio sam-codaio deleted the sloate-release-version branch August 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-codaio jonathan-codaio jonathan-codaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-codaio @jonathan-codaio