Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Update sonar dotnet #185

Closed
wants to merge 1 commit into from
Closed

Conversation

MiguelMarcelino
Copy link

No description provided.

@albertoadami
Copy link

@MiguelMarcelino is this sonar-csharp-plugin.jar file expected to be here? If we need it maybe will be nicer to have it in a bin directory

@MiguelMarcelino
Copy link
Author

@MiguelMarcelino is this sonar-csharp-plugin.jar file expected to be here? If we need it maybe will be nicer to have it in a bin directory

It is not. However, this branch is a draft for a reason: We will not be able just to bump the tool. This will require us to rework our parsing mechanism.

@@ -36,7 +36,7 @@ private static void Main()

var descriptions = new List<Description>();

var doc = XDocument.Load(@".res/sonar-csharp-rules.xml");
var doc = XDocument.Load(@".res/sonar-csharp-rules.json");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supposed to be.

@MiguelMarcelino
Copy link
Author

Closing this. A simple bump won't cut it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants