Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove relative path from hint path #55

Merged
merged 2 commits into from
Mar 18, 2020
Merged

fix: Remove relative path from hint path #55

merged 2 commits into from
Mar 18, 2020

Conversation

josemiguelmelo
Copy link
Contributor

@josemiguelmelo josemiguelmelo commented Mar 18, 2020 •
edited
Loading

#42

@josemiguelmelo josemiguelmelo requested review from lolgab, franciscodua and a team March 18, 2020 16:34
@josemiguelmelo josemiguelmelo self-assigned this Mar 18, 2020
gjsduarte
gjsduarte approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@gjsduarte gjsduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I didn’t know of that Generate Package Path property!
Good work! 👏

@josemiguelmelo
Copy link
Contributor Author

Thanks! 😄
It was a nice way of removing that relative path 👍

@josemiguelmelo josemiguelmelo merged commit 3ac60a1 into master Mar 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot-friendly branch March 18, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscodua franciscodua franciscodua approved these changes

@gjsduarte gjsduarte gjsduarte approved these changes

@lolgab lolgab Awaiting requested review from lolgab

Assignees

@josemiguelmelo josemiguelmelo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemiguelmelo @gjsduarte @franciscodua