Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving cleanup process in the unitests #52

Closed
gilv opened this issue Jul 27, 2016 · 3 comments
Closed

Improving cleanup process in the unitests #52

gilv opened this issue Jul 27, 2016 · 3 comments

Comments

@gilv
Copy link
Contributor

gilv commented Jul 27, 2016

Many unitests create temp data.
The way it works today is that each @test creates it's data and then
@After public void tearDown()
responsible to clean the generated data.

This is highly inefficient since it happens for each test and not per test suite. We need to change the logic, so that temp data will be created only once in the setup() method and cleaned at the end of the class run:
@AfterClass public static void classTearDown() throws Exception { }
A good reference is TestSwiftFileSystemLsOperations. It suppose to create temp data only once and then clean it after all tests complete it's executions. The way it works today is that data is created and cleaned per function.

@gilv
Copy link
Contributor Author

gilv commented Jul 27, 2016

@djalova Can you please look at it?

@djalova
Copy link
Contributor

djalova commented Jul 28, 2016

Will submit a PR soon.

@gilv
Copy link
Contributor Author

gilv commented Jun 21, 2017

resolved

@gilv gilv closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants