Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improved Tube v4.0 Release Party] Bugs, Features & Disscusion #1493

Closed
7 of 10 tasks
Anoaxx opened this issue Nov 15, 2022 · 7 comments
Closed
7 of 10 tasks

[Improved Tube v4.0 Release Party] Bugs, Features & Disscusion #1493

Anoaxx opened this issue Nov 15, 2022 · 7 comments
Assignees
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ 🥳🤩Yay!👏 legendary?

Comments

@Anoaxx
Copy link

Anoaxx commented Nov 15, 2022

So... v4.0 comes out on Chrome Web Store and i test it out. I mosty loves it, but there are some bugs i notice. Most of them are small or QoL size problems, but some are BIG.


  • B) Sometimes player cant load extension options. And even if i dont allow 60fps its still apears. I don't know what causes it. It was happening on older versions too, but less frequently and less annoying. Main differance is that now i must open new tab(and sometimes still dont repairs) but then refresh repairs this problem. Even if it can't be repaired entirely just try to change this behaviour to repair itself after refresh & optionally add some sort of tip or warning that says "if something dont work try refresh the page or reinstall extension". How many times i was forced to refresh or reinstall extension was hilariously enormous & colossal due to something stop working in time. (Edit by @ImprovedTube: Sure reinstalling matters? [We could tirgger more reloads after some of the setttings are set])
    imageimage
  • A) [4.0.1] 'Limit Page Width:off' breaks home page! (www.youtube.com/) #1492 ( Disabling Limit Page Width causes Main Page(www.youtube.com/) to never load(& if you change this option on main page, only if you refresh the page makes the difference). Even if load then videos are sticking out of the screen. Prefferably repair & Add options to disable width limit seperately for non video pages(like main page, subs feed or channel) and video pages. )


  • 1) Desc on Video Page has problems. It's doubled(old & new ui), if you use "hide details" old one disappears as long as this option remains enabled. BUT! if you change desc appearance to "Expanded" then New UI desc disapears forever and you are forced to use old one. Prefferably to repair and add options to choose which one you wanna use. (And repair hiding detail buttons cause they still dont work)


Smaller problems:

  • F) I dont know if this is intentional or not but Crop chapter titles & Loudness Normalization are enabled by default.

  • D) If appearance of Header is set to "Hover" or "Hover on video page" wild static box appears above video. image

    • asking if it ever happened again @Anoaxx
  • C) Hiding 5s skip animation stop working. (Reported twice #1496)
    imageimage

  • E) If you have comments appearance set to "collapsed" it breaks comments entirely on YTShorts. Its says "Show more" but you can't click

imageimage

  • G) Using "Hover" Header option colapses new channel video tab(removing recently uploaded and popular buttons.



#2029


In summary, this update is seriously good. I love it. There are some bugs here and there, but still its solid update. I have high hopes that this post is not gonna be forgotten cause i love helping you guys and i wanna extension to be better. Im doing this since 2.0 if i remember correctly and im using Improved Tube since then with maybe one week break cause i was angry about no updates and extension stops working properelly and i was trying using other extensions but nothing was that good as IT. I wish you all the best and stay awesome! Love Ya! Peace!

/Anoax

@Anoaxx Anoaxx added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) important Critical or common. Thus to prioritize labels Nov 15, 2022
@Anoaxx Anoaxx removed Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Nov 15, 2022
@falcon4fun
Copy link

falcon4fun commented Nov 15, 2022

More: Theater mode is broken when opening video in new tab. Opens in default youtube mode instead of Improved Tube one. Tab needs to be refreshed manually.

Update: Fixed here. #1493 (comment)

@Anoaxx
Copy link
Author

Anoaxx commented Nov 15, 2022

More: Theater mode is broken when opening video in new tab. Tab needs to be refreshed manually.

Can you provide your options .json file?(to have it: open extension menu -> click 3 dots in right upper corner -> settings -> Back uo & reset -> Export Settings -> Download -> Pack it into .rar file -> Put it here)

@falcon4fun
Copy link

falcon4fun commented Nov 15, 2022

Can you provide your options .json file?(to have it: open extension menu -> click 3 dots in right upper corner -> settings -> Back uo & reset -> Export Settings -> Download -> Pack it into .rar file -> Put it here)

Very important code :kappa: :)

{"player_size":"fit_to_window"}

It's all. I always try use default configuration with minimum changes before reporting :)

@Anoaxx
Copy link
Author

Anoaxx commented Nov 15, 2022

Very important code :kappa: :)

{"player_size":"fit_to_window"}

It's all. I always try use default configuration with minimum changes before reporting :)

It happens every time? Cause i can't reproduce

@falcon4fun
Copy link

Okey. Then tell me, how the Theater mode is broken with this option enabled?

Ordinary YT behavior: Theater is not fitting whole window
Normal ImprovedTube behavior with theater "fit to window": fills whole window
Broken ImprovedTube behavior:
Open in new tab - Ordinary YT behavior
Refresh page - Normal ImprovedTube behavior

Version
ImprovedTube:

  1. git clone
  2. previous (3.x branch)
  3. release

can't reproduce

Strange. I've seen more reports: https://github.com/code-for-charity/ImprovedTube-for-YouTube/issues?q=theater
It is broken for ~month or smth. Don't remember actual time. After re-deisgn.

I can double-check it on ordinary stable Chrome version because I'm on RP (109.x).
And it's like manifest / browser API changes or smth.

You're right. I see extension works on stable 107.x branch. And it seems to be truth. 107.x Release date 10.25. That day my build switched to +1 version =109.x. Meeh.

Will check more with clean profile because I see that extension is already MV3 so it supposed to work. Sad.

@Anoaxx
Copy link
Author

Anoaxx commented Nov 15, 2022

I personally use "Full Window" and it never break like this. Maybe that gonna help

@falcon4fun
Copy link

Maybe that gonna help

Thx. Whole Chrome profile (appdata\local\google\chrome*) bugged in interesting way.
Clean profile (directory rename) with re-sync and manual reconfiguration of all extensions fixed problem.
Another ways not helped here like:

  1. Creating new profile from profile manager
  2. Removing chrome all Chrome history (previously removing sync)
  3. Manually removing service workers, extension setting, extensions, preferences, secure preferences, web data, cookies and etc not worked.

Now works fine. Thx for help. I would sit and wait for ages thinking it's Chrome branch or extension bug :)

@ImprovedTube ImprovedTube added the Bug Bug or required update after YouTube changes label Nov 15, 2022
@ImprovedTube ImprovedTube added the Feature request Wish or idea label Nov 16, 2022
@dodieboy dodieboy mentioned this issue Dec 6, 2022
@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes and removed important Critical or common. Thus to prioritize Bug Bug or required update after YouTube changes labels Mar 12, 2023
@ImprovedTube ImprovedTube added the 🥳🤩Yay!👏 legendary? label Mar 21, 2023
@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Apr 29, 2023
@ImprovedTube ImprovedTube removed their assignment May 10, 2023
@ImprovedTube ImprovedTube added good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Oct 19, 2023
@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ 🥳🤩Yay!👏 legendary?
Projects
Status: Done
Development

No branches or pull requests

3 participants