Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the reverse playlist option is enabled, the playlist's 'Loop' button has a "1" character flickering on and off inside, and causes tooltips and context menus to instantly close #1683

Closed
AngryCarrot789 opened this issue May 17, 2023 · 6 comments
Assignees
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ z Opera GX occuring in Opera GX (only?)

Comments

@AngryCarrot789
Copy link

AngryCarrot789 commented May 17, 2023

Bug Report:

BUG: Title, and it also causes a huge amount of lag after around 5-10 minutes; video keep buffering and starts lowering the resolution

HOW: Enable the "reverse playlist" option in the extension (Playlist > Reverse). Then, open a playlist (e.g. uploads from a channel). And then irregardless of if reverse is actually enabled or not, eventually the loop button (on the top left side of the playlist panel) will have a 1 inside that keeps showing and going invisible

It seems to happen more often when it autoplays onto the next video. When you refresh the page, it seems to fix it

EXPECTED (/preferred) behavior: It not to flick and cause all tooltips to instantly close

Screenshots:
image

/ ⚬ Context:

Setup:

⚬ ImprovedTube Version: 4.9
⚬ Browser: OperaGX (latest version; 98.0.4759.64, chromium version 112.0.5615.165). The same thing also happens on microsoft edge (chromium edition, not sure the specific version but it's the latest version)
⚬ Settings:
⚬ OS: Windows 10
⚬ Device:

Here's the call stack just in case... i tried to figure it out myself but it's hella obfuscated lol
image

@AngryCarrot789 AngryCarrot789 added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 17, 2023
@ImprovedTube ImprovedTube added the z Opera GX occuring in Opera GX (only?) label May 17, 2023
@ImprovedTube
Copy link
Member

hi @AngryCarrot789 thank you so much! may i/we use some of your 200 apps?

  1. While we possibly it in our code quicky, youtube's behavior with this playlist widget also is mysterious from a far yet: Reverse playlist button no longer functioning. - Remedy: Add Shortkey (& extra position?) #1544 (scroll down, no other thread in our repo compares to this)

also

  1. since i first saw the OperaGX ad, i feared the correlation with our users might be significant! - in the mean time we only learnd about a bunch of unique bugs only occuring in OperaGX - still have hopes OperaGX might be changing quickly still - or the correlation might not be that hight (while weighting urgency, starting with Chrome), yet the amount of our OperaGX users seems to only increase /exponentially😪😅

@ImprovedTube
Copy link
Member

Please Sponsor us, please?
@operasoftware

Wont you?

Then we can fix OperaGX bugs daily & wont even mind to be delivered with it by default 😎

@AngryCarrot789
Copy link
Author

AngryCarrot789 commented May 17, 2023

I could be wrong but it seems like it's some sort of recursive call of the ImprovedTube.playlistRepeat() function, in playlist.js (https://github.com/code-charity/youtube/blob/master/js%26css/web-accessible/www.youtube.com/playlist.js), where the 100 is the time in milliseconds?

When you collapse the playlist panel, the header jumps between "Next: " and "End of playlist"

@ImprovedTube
Copy link
Member

ImprovedTube commented May 17, 2023

you're making me feel 🤫😳 you might be a contributor, we've been waiting for @AngryCarrot789

milliseconds

Yes, yet i dont know this code better than you. Lost our author in 2022

... * just in case :D you end up testing repeatedly, i suggest this with alt+x ( chrome://extensions/shortcuts )

@AngryCarrot789
Copy link
Author

I just removed the line setTimeout(function () {ImprovedTube.playlistRepeat()}, 100); and that seemed to fix it. Not sure if it broke the repeat function... but I don't use it anyway so 🙃
File path is: C:\Users\<username>\AppData\Roaming\Opera Software\Opera GX Stable\Extensions\<extension id>\4.9_0\js&css\web-accessible\www.youtube.com\playlist.js

ImprovedTube added a commit that referenced this issue May 18, 2023
ImprovedTube added a commit that referenced this issue May 18, 2023
ImprovedTube added a commit that referenced this issue May 18, 2023
This reverts commit 4a86880.
@ImprovedTube
Copy link
Member

@AngryCarrot789 can/did you try a larger interval in operaGX?

// || (option === false && svg !== 'M21,13h1v5L3.93,18.03l2.62,2.62l-0.71,0.71L1.99,17.5l3.85-3.85l0.71,0.71l-2.67,2.67L21,17V13z')

hi @dodieboy
https://github.com/code-charity/youtube/commits/94fe08470d763be7ebb3c026cb9fb97c0780281a/content-scripts/website-context/youtube-features/playlist.js?browsing_rename_history=true&new_path=js&original_branch=master

ImprovedTube added a commit that referenced this issue Jan 12, 2024
ImprovedTube added a commit that referenced this issue Jan 12, 2024
ImprovedTube added a commit that referenced this issue Jan 12, 2024
ImprovedTube added a commit that referenced this issue Jan 12, 2024
This reverts commit 4a86880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ z Opera GX occuring in Opera GX (only?)
Projects
None yet
Development

No branches or pull requests

2 participants