Playback speed not working anymore ( for video duration 135s-260s )

[mlcivilengineer]

Bug Report:

⚬ BUG: The playback speed feature is not working anymore. The videos keep playing at 1x no matter what speed I choose
⚬ HOW: Just put the playback to 2x and the videos will be playing at 1x.

Setup:

⚬ ImprovedTube Version: 4.321
⚬ Browser: Chrome 116.0.5845.141 64 bits
⚬ OS: Windows 11

[fernplant]

Im having issues with speed control also. 2 days ago there was some kind of change. Mine no longer defaults to the 1.5x I have in settings, it goes to regular 1x. I am able to manually change it using keyboard shortcuts though

[mlcivilengineer]

Installing from source from the commit 29e1252 solved the issue. So it has to be some change that came after that commit.

I suspect it has to be this change 7b3020f from the pull request #1729
It rewrote some of the playback speed logic and it might have introduced a regression.

[ImprovedTube]

thanks! @mlcivilengineer @fernplant
Speed wasnt applied for video duration 135s-260s as i missed parentheses in the code when checking for music.

[will09122000]

This is still broken for me regardless of video duration.

⚬ ImprovedTube Version: 4.323
⚬ Browser: Version 116.0.5845.140 (Official Build) (arm64)
⚬ OS: macOS 13.5.1 (22G90)

[mlcivilengineer]

The issue resolved for me. Make sure that you are on the latest release which was updated yesterday, September 4, 2023. They don't seem to change the version number for minor patches, so it is hard to know which release you are actually using. I would just uninstall it and install it again

[will09122000]

Pretty sure I'm on the latest version, still hasn't fixed the issue. Are you using the beta version?

The ID of the Chrome extension is lodjfjlkodalimdjgncejhkadjhacgki, not sure if that can be used to identify the version?

[mlcivilengineer]

Yea, I have used the extension today and noticed that sometimes it does not work right off the bat. I have to refresh the page for it to work..honestly I don't even know how to replicate the bug consistently. I guess I just open the browser, go to youtube.com, pick a video and then it will be in the normal 1x speed, I then refresh the page and it will be in the correct speed that I set up (1.75x). The next videos that I pick will then be in the correct speed, but after some minutes the bug returns. Might just compile from source and go back to a previous version until this is sorted out.

[mlcivilengineer]

I think the problem is also masked and harder to reproduce because if you disable the extension, pick a video and manually set it to 1.75x speed. The following videos that you click will have the 1.75x speed, so youtube keeps track of your tab session and sets it to the speed that you chose in the first video. If you close the tab, and open a new one, go to youtube and click a video, it will have the 1x speed again, so it is session based.

Anyways, I created a new issue #1750

[fernplant]

Just wanted to update that for me, its now fixed

[mlcivilengineer]

Yea @ImprovedTube did an awesome job and fixed it in the issue #1750 :) kudos to him