Autoplay fix & more #1719
Autoplay fix & more #1719
Conversation
This should fix disable autoplay still play for a milisecond before the video pause when video is open using new tab. code-charity#1703
childHandler will skip all the check for iron-iconset-svg element now as we do not have feature that need it for now. which will fix a bit of lag when open youtube on new tab
added yt-icon-shape
| @@ -150,6 +154,7 @@ ImprovedTube.ytElementsHandler = function (node) { | |||
| } else if (id === 'movie_player') { | |||
| if (!this.elements.player) { | |||
| ImprovedTube.elements.player = node; | |||
| ImprovedTube.elements.player.stopVideo(); | |||
There was a problem hiding this comment.
why? /worth documenting (@dodieboy)
There was a problem hiding this comment.
When youtube first open, too many things is loading. From youtube default code to our loop code. Therefore, the pause code sometimes will lag which cause the few milisecond play time. That what I feel
There was a problem hiding this comment.
That's why I stop the video from loading first until everything is ready
There was a problem hiding this comment.
oh, my bad! (it is just like @dodieboy said already & the first commit does nothing else)
So not to delay playback for everybody else, it should be conditional to ImprovedTube.storage.player_autoplay === false.
| html[it-hide-download-button='hidden'] #menu button:has(svg path[d^="M17 18V19H6V18H17ZM16.5 11.4"]), | ||
| html[it-hide-download-button='hidden'] #flexible-item-buttons button:has(svg path[d^="M17 18V19H6V18H17ZM16.5 11.4"]) { | ||
| html[it-hide-download-button='hidden'] #menu button:has(svg path[d^="M17 18v1H6v-1h11zm-.5-6.6-.7-.7-3.8 3.7V4h-1v10.4l-3.8-3.8-.7.7"]), | ||
| html[it-hide-download-button='hidden'] #flexible-item-buttons button:has(svg path[d^="M17 18v1H6v-1h11zm-.5-6.6-.7-.7-3.8 3.7V4h-1v10.4l-3.8-3.8-.7.7"]) { |
There was a problem hiding this comment.
the matches can be shorter predicting minor change. Even a few chars are unlikely to exist twice (and if ever, that's probably better than the feature failing.) (@dodieboy )
|
thanks a lot! relieved to see you again! |
|
uploading to the stores. |
|
Can we have another solution for the autoplay? With autoplay on this causes the player to fade to black from a preview icon into suddenly showing video. Essentially it causes two transitions, including one that's really jarring instead of just one that goes from icon to video. Possibly something like mentioned in the comment above Since it essentially resets the player it also causes issues with timestamps not working #1724 |
|
while ImprovedTube.elements.player.stopVideo() does fix split second play I feel its too brutal. |
| if (node.nodeName !== 'SCRIPT' && node.nodeName !== 'iron-iconset-svg' && node.nodeName !== 'svg' && node.nodeName !== '#text'&& node.nodeName !== '#comment' && node.nodeName !== 'SPAN' && node.nodeName !== 'DOM-IF' && node.nodeName !== 'DOM-REPEAT') { | ||
| var children = node.children; | ||
| this.ytElementsHandler(node); | ||
| if (node.nodeName === 'SCRIPT' || node.nodeName === 'iron-iconset-svg' || node.nodeName === 'svg' || node.nodeName === '#text' || node.nodeName === '#comment' || node.nodeName === 'SPAN' || node.nodeName === 'DOM-IF' || node.nodeName === 'DOM-REPEAT') { |
There was a problem hiding this comment.
Everything in 10aef10 is pure semantics and doesnt do anything. Browser js engine will optimize it to same logical form when loading the page. Would made sense if this was assembly, basic, pascal, even C somewhere in mid nineties with bad compilers, but nowadays its all automagically optimized away.
There was a problem hiding this comment.
yes (!== .. && vs === .. || just improves readability, might saves 2 nanoseconds per cycle) )
yet of course childHandler is critical.
everything
besides if (node.getAttribute('itemprop')) ) { ...
|
assuming this is best for today: f6d277b wish🤫the project would/could get you guys' attention even more 😅😅🤔, |
I tried to fix disable autoplay play for a few mili second before pause when video is open on new tab. On my computer, it is fixed but not sure will it work for slower device, so i also did some optimization for startup code hoping to fix the problem.
This PR also update hide detail button svg code