Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: copy video transcript #1792

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: copy video transcript #1792

merged 2 commits into from
Oct 17, 2023

Conversation

asifurrahaman754
Copy link
Member

@asifurrahaman754 asifurrahaman754 commented Oct 14, 2023 •
edited
Loading

Issue #1761

Added YouTube video transcript copy feature.

You can find the option in: Appearance -> Details -> Copy transcript

@asifurrahaman754 asifurrahaman754 changed the title add copy transcript feature feat: copy video transcript Oct 15, 2023
@ImprovedTube
Copy link
Member

🥰🥰🥰

@ImprovedTube ImprovedTube merged commit 1585931 into code-charity:master Oct 17, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 17, 2023 •
edited
Loading

thank you so much! @asifurrahaman754
seems while the player is still loading it catches part the first few lines of the transcript, yet when the page finished loading, it will (always?) say "...failed...."

youtube/js&css/extension/www.youtube.com/appearance/sidebar/sidebar.css

Line 35 in d8733ea

html[data-page-type=video][it-transcript='true'] *[target-id*='transcript'] ytd-engagement-panel-section-list-renderer #content

@asifurrahaman754
Copy link
Member Author

thank you so much! @asifurrahaman754 seem,s while the player is still loading it catches part the first few lines of the transcript, yet when the page finished loading, it will (always?) say "...failed...."

youtube/js&css/extension/www.youtube.com/appearance/sidebar/sidebar.css

Line 35 in d8733ea

html[data-page-type=video][it-transcript='true'] *[target-id*='transcript'] ytd-engagement-panel-section-list-renderer #content

The popup needs to be turned off to copy int he clipboard because the document is not focused when popup is open

@ImprovedTube
Copy link
Member

hi @asifurrahaman754 figured that. yet it always works while loading and not beyond (for the transcripts i tried)

ImprovedTube added a commit that referenced this pull request Oct 20, 2023
@ImprovedTube
undoing #1792 (for today)
5d05160
@asifurrahaman754 asifurrahaman754 deleted the copy-transcript branch October 22, 2023 17:02
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
@ImprovedTube
Merge pull request #1792 from asifurrahaman754/copy-transcript
ab4be6a
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
@ImprovedTube
undoing #1792 (for today)
3660e5d
@ImprovedTube ImprovedTube mentioned this pull request Jul 9, 2024
Open
@ImprovedTube ImprovedTube added the Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle) label Jul 9, 2024
@ImprovedTube ImprovedTube self-requested a review August 9, 2024 18:44
@ImprovedTube
Copy link
Member

Greetings! @asifurrahaman754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImprovedTube ImprovedTube Awaiting requested review from ImprovedTube

Assignees

@ImprovedTube ImprovedTube

@asifurrahaman754 asifurrahaman754

Labels
Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle)
Projects
Priority A
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asifurrahaman754 @ImprovedTube