Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Write js script to remove automatically generated folders in the node-mongo CLI during development #42 #218

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

oyenuga17
Copy link
Contributor

@oyenuga17 oyenuga17 commented Jun 10, 2023

This pull request makes the following changes:

  • Fixes code-collabo/node-mongo#42

General checklist

  • File or folder now contains changes as specified in the issue i worked on
  • I have linked the issue I worked on to this pull request submitted by me

Testing checklist

Replace this text with the testing checklist from the issue this pull request fixes.

Ping @code-collabo/node-mongo-cli

@oyenuga17 oyenuga17 changed the title added cleanup.js file Fix: added cleanup.js file Jun 10, 2023
@oyenuga17 oyenuga17 changed the title Fix: added cleanup.js file Fix : Write js script to remove automatically generated folders in the node-mongo CLI during development #42 Jun 10, 2023
@oyenuga17
Copy link
Contributor Author

@Ifycode please review

@Ifycode
Copy link
Contributor

Ifycode commented Sep 17, 2023

Thank you @oyenuga17
Reviewing this week once our community starts rolling again.
Expect my feedback soon.

@Ifycode
Copy link
Contributor

Ifycode commented Sep 26, 2023

I've reviewed this @oyenuga17
It doesn't work.
I will merge yours into a PR where I have fixed the changes, then you'll be able to see the solution/correction I cam up with.
Nice attempt though.

@Ifycode Ifycode changed the base branch from develop to cleanup September 26, 2023 02:11
@Ifycode Ifycode merged commit 4ae63a2 into code-collabo:cleanup Sep 26, 2023
@Ifycode
Copy link
Contributor

Ifycode commented Sep 26, 2023

@all-contributors add @oyenuga17 for code

@allcontributors
Copy link
Contributor

@Ifycode

I've put up a pull request to add @oyenuga17! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write js script to remove automatically generated folders in the node-mongo CLI during development
2 participants