Remove organization memberships #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update drops the `organization_memberships` table, removes all related temporary migration tasks from the `priv/repo/scripts` directory and removes all occurrences of organization memberships throughout the API codebase. Resolves #718.
joshsmith
force-pushed
the
718-remove-organization-memberships
branch
from
d689500
to
f54e6a3
Compare
joshsmith
approved these changes
Mar 18, 2017
|
This looks really great @christopherstyles. I especially like that you took the extra time to remove the migration tasks. LGTM! |
|
Thanks for the kind review @joshsmith, much appreciated! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Once project users were migrated away from “organization memberships”, and permissions were fully working and tested, the organization memberships entity and associated tasks/logic were no longer needed.
This update makes the following changes:
organization_membershipstable.priv/repo/scriptsdirectoryReferences
Resolves #718.