Add task to inbox task list when created from GitHub #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
add-task-to-task-list
branch
3 times, most recently
from
15b281a
to
7c8931c
Compare
begedin
approved these changes
Aug 31, 2017
| project_ids |> Enum.each(fn project_id -> | ||
| project = Project |> Repo.get_by(id: project_id) | ||
| insert(:task_list, project: project, inbox: true) | ||
| end) |
There was a problem hiding this comment.
Something to consider, I don't believe in a real use scenario, projects can get created without associated task lists. Maybe we should upgrade our project factory so a set of task lists is always created? As a separate issue, of course.
|
@begedin can you merge and create that issue? |
Fix tests by adding in inbox task list
joshsmith
force-pushed
the
add-task-to-task-list
branch
from
7c8931c
to
aa66677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This change makes it so a task created on GitHub is synced to the
inboxTaskListfor the givenProject.Open to thoughts on how to improve the logic or the tests.
References
Fixes #872