Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maker: Setup page improvements and initialization cleanup #13286

Merged
merged 7 commits into from
Feb 17, 2017
Merged

Maker: Setup page improvements and initialization cleanup #13286

merged 7 commits into from
Feb 17, 2017

Commits on Feb 16, 2017

  1. Remove unused component reset code

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    ae2aaf0 View commit details
    Browse the repository at this point in the history

  2. Correcly annotate some static methods

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    e8c352c View commit details
    Browse the repository at this point in the history

  3. Setup page improvements 

    1. The re-detect button no longer triggers a setup page reload, because we're now able to initialize from scratch multiple times on a page.

2. Re-detect is disabled during board detection, to avoid any confusion.

3. I've introduced some artifical delay into the setup steps - it's more reassuring and satisfying to see each step spin for a moment before turning green, than to have most steps succeed instantaneously.

4. Issues with dropped serialport traffic meant we sometimes didn't manage to enable or disable all the LEDs at once on successful connection.  I've made success animate the LEDs in sequence instead, which is not only more dynamic and interesting, it seems to be much more reliable.  We'll address general issues with dropped messages soon, but for now making the setup page seem more reliable will help.
    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    3648c87 View commit details
    Browse the repository at this point in the history

  4. camelCase state stauses

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    5d8747a View commit details
    Browse the repository at this point in the history

  5. More concise (review feedback)

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    0f589fc View commit details
    Browse the repository at this point in the history

  6. Express forEachLedInSequence better

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    ecad798 View commit details
    Browse the repository at this point in the history

  7. No magic strings for setup steps

    @islemaster
    islemaster committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    89c16f4 View commit details
    Browse the repository at this point in the history