DTL (Test > Levelbuilder): 5edb30f1 #20843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTP (Test > Production: 6a5118a)
DTP (Test > Production: a5089d3)
…ect instead of always CSP
These two tests were consistently failing on my local machine, because the order of the inner results list of the levelgroup results was different, even though the tests attempt to prevent randomness from being a factor. I'm not sure what the root cause of that is, but the right solution is not to assert a particular order if we don't care what the resulting order is. I've extracted a couple of helper methods (addressing a TODO left by Asher) that assert the result sets match without enforcing a particular order.
Fix summer workshop enrollment emails to display actual workshop subj…
…r_api RegionalPartner for_user api
Before, we were checking `:maker_discount` authorization before rendering /maker/home, which restricted access to teachers. Now, we skip that check for /maker/home. Instead, when rendering home we have an explicit `authenticate_user!` call which redirects to the sign-in page if the current user is not signed in, and will redirect them back to /maker/home after they sign in successfully.
DTT (Staging > Test) [robo-dtt]
production -> staging
…er-integration-tests Revert "Craft designer integration tests"
Maker: Can start new App Lab app with Maker enabled from /maker/home
add userId to firehose putRecord calls from javascript
add user_id to firehose putRecord requests in ruby
DTT (Staging > Test) [robo-dtt]
Restore ability to execute Redshift queries from production
DTT (Staging > Test) [robo-dtt]
remove duplicate 'signup' id to show correct video in fallback player
Manage students - update with new strings based on spec
DTS (Levelbuilder > Staging) [robo-dts]
Updated script admin menu
DTT (Staging > Test) [robo-dtt]
Add a couple more Game Lab Jr blocks
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.